Skip to content

docs: add S2 audit skill#10160

Merged
reidbarber merged 5 commits into
mainfrom
s2-audit-skill
Jun 17, 2026
Merged

docs: add S2 audit skill#10160
reidbarber merged 5 commits into
mainfrom
s2-audit-skill

Conversation

@reidbarber

@reidbarber reidbarber commented Jun 5, 2026

Copy link
Copy Markdown
Member

Adds a new spectrum-audit that helps AI agents audit a codebase for Spectrum best practices.

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Look at the latest Agent Skills Changes comment on this PR. Run the command listed under Install -> React Spectrum S2. In the CLI prompt, select spectrum-audit as the skill to install.

Invoke the skill in your preferred AI tool.

🧢 Your Project:

@rspbot

rspbot commented Jun 5, 2026

Copy link
Copy Markdown

@reidbarber reidbarber changed the title [WIP] docs: add S2 audit skill docs: add S2 audit skill Jun 17, 2026
@rspbot

rspbot commented Jun 17, 2026

Copy link
Copy Markdown

@rspbot

rspbot commented Jun 17, 2026

Copy link
Copy Markdown

@rspbot

rspbot commented Jun 17, 2026

Copy link
Copy Markdown

Agent Skills Changes

Added (9)
Modified (1)
Install

React Spectrum S2:

npx skills add https://d1pzu54gtk2aed.cloudfront.net/pr/9c10833718253786b1c267a2919193106b0dbdb7/

React Aria:

npx skills add https://d5iwopk28bdhl.cloudfront.net/pr/9c10833718253786b1c267a2919193106b0dbdb7/

@LFDanLu LFDanLu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ran locally against our prototypes repo and it caught our UNSAFEs haha.

- Vite/Rollup/React Router: `build.rollupOptions.output.manualChunks` returning `'s2-styles'` for `macro-*.css` and `@react-spectrum/s2/*.css`.
- **Severity:** High.

### lightningcss minification

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we could add reference links to the docs for these so if they fail they have something to look at

@reidbarber reidbarber added this pull request to the merge queue Jun 17, 2026
Merged via the queue into main with commit a064c19 Jun 17, 2026
30 checks passed
@reidbarber reidbarber deleted the s2-audit-skill branch June 17, 2026 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants