Cursor buildllm token context protocol 593a#1645
Conversation
Co-authored-by: nicsins <nicsins@gmail.com>
Co-authored-by: nicsins <nicsins@gmail.com>
Co-authored-by: nicsins <nicsins@gmail.com>
Co-authored-by: nicsins <nicsins@gmail.com>
Co-authored-by: nicsins <nicsins@gmail.com>
Co-authored-by: nicsins <nicsins@gmail.com>
…ous-innovation-agency-3733 Build autonomous innovation agency
Co-authored-by: nicsins <nicsins@gmail.com>
Co-authored-by: nicsins <nicsins@gmail.com>
Co-authored-by: nicsins <nicsins@gmail.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f8f256704b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| from typing import List | ||
|
|
||
| from ... import schemas | ||
| from ..orchestrator import PublishResult |
There was a problem hiding this comment.
When the FastAPI app starts, main.py imports ListingOrchestrator, which imports ChannelPublisher, and this line immediately imports PublishResult back from the still-initializing orchestrator module. With the declared service dependencies installed, that circular import raises ImportError: cannot import name 'PublishResult' from partially initialized module, so uvicorn app.main:app cannot start; put PublishResult in this module or a separate schemas/results module instead.
Useful? React with 👍 / 👎.
| else: | ||
| response_text = self._call_openrouter(model, api_key, messages) | ||
| except Exception as exc: | ||
| self.root.after(0, lambda: self._handle_error(exc)) |
There was a problem hiding this comment.
If an Ollama/OpenRouter call fails, this schedules a lambda that closes over the except ... as exc variable. Python clears that variable after the except block, so when Tk later runs the callback it raises a NameError instead of calling _handle_error, leaving the UI busy with the Send button disabled. Capture the value in the lambda/default argument or pass a preformatted message.
Useful? React with 👍 / 👎.
| run: | | ||
| # NOTE: put your own distribution build steps here. | ||
| python -m pip install build | ||
| python -m build |
There was a problem hiding this comment.
In this workflow, the release job runs python -m build from the repository root immediately after checkout, but I checked the root for pyproject.toml, setup.py, or setup.cfg and none exists. That means every published release will fail in release-build before dist/ is uploaded or PyPI publishing can run; either add package metadata at the root or cd to the package that actually has it before building.
Useful? React with 👍 / 👎.
2 participants
No description provided.