Fix heap issues with virtual address #2391
Open
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First implementation didn't take into account that the mappings for the heap grow on linux, leading to wasted ranges in virtual address and quickly running out of them. This PR makes it so that when the heap mapping is retrieved its total size is faked to 3.5GB (leaving 700MB of ranges for modules).
Worth noting that this PR is going to break virtual address on windows (well its already broken, but it will make things worse). The heap on windows work differently, each module has its own heap and therefore scattered map. A proper fix for windows would be to merge all modules' heap under a unique heap but that's going to involve a lot more hacks than this hence why I'm reserving this for another PR.