Skip to content

Conversation

@Jaehwa-Noh
Copy link
Contributor

@Jaehwa-Noh Jaehwa-Noh commented Jan 15, 2026

Fix #1874

What I have done and why

Current setting just set LTR forcefully.
Align and Direction set to Left without concern of language characteristic.

https://developer.android.com/reference/kotlin/androidx/compose/ui/text/style/TextAlign
image

https://developer.android.com/reference/kotlin/androidx/compose/ui/text/style/TextDirection
image

I think we would concern the language characteristic.

Here is the result.

Screen_recording_20260115_215750.mp4

Change-Id: I9d9180446adea0e34b61f1cfb5d424bf264f130a
@Jaehwa-Noh Jaehwa-Noh requested a review from dturner as a code owner January 15, 2026 13:09
@gemini-code-assist
Copy link

Summary of Changes

Hello @Jaehwa-Noh, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the application's internationalization capabilities by modifying how text direction and alignment are handled within the design system's typography. Previously, text was forcefully set to Left-to-Right and left-aligned. The updated configuration now dynamically adjusts text direction and alignment based on the content's language characteristics, ensuring a more natural and accessible user experience for diverse linguistic contexts.

Highlights

  • Text Direction and Alignment: Updated textDirection from TextDirection.Ltr to TextDirection.ContentOrLtr and textAlign from TextAlign.Left to TextAlign.Start across all defined TextStyle objects in NiaTypography.
  • Internationalization Improvement: This change allows the application to respect language characteristics for text rendering, supporting both Left-to-Right (LTR) and Right-to-Left (RTL) languages more effectively, addressing issue [Bug]: Text artifacts in RTL layout #1874.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly addresses an internationalization issue by changing hardcoded left-to-right text alignment and direction to be content-aware. This will ensure text is displayed correctly for both LTR and RTL languages. The changes are applied consistently across all text styles in the app's typography definition. My main feedback is a suggestion to refactor the typography definitions to reduce code duplication, which would improve long-term maintainability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Text artifacts in RTL layout

1 participant