Skip to content

fix(core): skip invisible objects before intersectObject #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nartc merged 1 commit into from
Mar 18, 2026
Merged

fix(core): skip invisible objects before intersectObject #81

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion libs/core/src/lib/events.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,19 @@ export function createEvents(store: SignalState<NgtState>) {
const duplicates = new Set<string>();
const intersections: NgtIntersection[] = [];
// Allow callers to eliminate event objects
const eventsObjects = filter ? filter(state.internal.interaction) : state.internal.interaction;
const allEventsObjects = filter ? filter(state.internal.interaction) : state.internal.interaction;

// filter out invisible objects
const eventsObjects: THREE.Object3D[] = [];
for (const eventsObject of allEventsObjects) {
let current: THREE.Object3D | null = eventsObject;
while (current) {
if (!current.visible) break;
current = current.parent;
}

if (!current) eventsObjects.push(eventsObject);
}

if (!state.previousRoot) {
// Make sure root-level pointer and ray are set up
Expand Down
33 changes: 33 additions & 0 deletions libs/soba/src/performances/detailed.stories.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,34 @@ import { NgtsOrbitControls } from 'angular-three-soba/controls';
import { NgtsDetailed } from 'angular-three-soba/performances';
import { storyDecorators, storyFunction } from '../setup-canvas';

@Component({
template: `
<ngts-detailed [distances]="[0, 50]">
<ngt-group>
<ngt-mesh (pointermove)="onHover()">
<ngt-icosahedron-geometry *args="[10, 3]" />
<ngt-mesh-basic-material color="hotpink" wireframe />
</ngt-mesh>
</ngt-group>

<ngt-mesh>
<ngt-icosahedron-geometry *args="[10, 1]" />
<ngt-mesh-basic-material color="lightblue" wireframe />
</ngt-mesh>
</ngts-detailed>

<ngts-orbit-controls [options]="{ enablePan: false, enableRotate: false, zoomSpeed: 0.5 }" />
`,
schemas: [CUSTOM_ELEMENTS_SCHEMA],
changeDetection: ChangeDetectionStrategy.OnPush,
imports: [NgtsDetailed, NgtArgs, NgtsOrbitControls],
})
class WithEventDetailedStory {
protected onHover() {
console.log('hovered');
}
}

@Component({
template: `
<ngts-detailed [distances]="[0, 50, 150]">
Expand Down Expand Up @@ -41,3 +69,8 @@ export const Default = storyFunction(DefaultDetailedStory, {
camera: { position: [0, 0, 100] },
controls: false,
});

export const WithEvent = storyFunction(WithEventDetailedStory, {
camera: { position: [0, 0, 100] },
controls: false,
});