build: avoid syntax errors in generated JS file#32963
Open
crisbeto wants to merge 1 commit intoangular:mainfrom
Open
build: avoid syntax errors in generated JS file#32963crisbeto wants to merge 1 commit intoangular:mainfrom
crisbeto wants to merge 1 commit intoangular:mainfrom
Conversation
The `web_test_suite` rule generates a JS file on-the-fly which inserts CSS dependencies into the current page. Currently this file uses double quotes for the string which breaks if there are new lines in the file. This is currently blocking angular#32961 and angular#32962. These changes switch to using multi-line strings to avoid the issue.
angular-robot
bot
added
the
area: build & ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
web_test_suiterule generates a JS file on-the-fly which inserts CSS dependencies into the current page. Currently this file uses double quotes for the string which breaks if there are new lines in the file. This is currently blocking #32961 and #32962.These changes switch to using multi-line strings to avoid the issue.