refactor: remove makeRuntime facades from File and Ripgrep#22513
Merged
kitlangton merged 1 commit intodevfrom Apr 16, 2026
Merged
refactor: remove makeRuntime facades from File and Ripgrep#22513kitlangton merged 1 commit intodevfrom
kitlangton merged 1 commit intodevfrom
Conversation
Delete leftover facade exports and makeRuntime from file/index.ts and file/ripgrep.ts. Migrate all callers (debug CLI commands, tests) to use AppRuntime.runPromise with Service.use directly. Also simplifies debug/file.ts handlers to drop unnecessary Effect.gen wrappers, adds missing bootstrap() to FileTreeCommand, and consolidates ripgrep tests into a single describe block using Service.use.
kitlangton
force-pushed
the
kit/residual-facade-cleanup
branch
from
4408774 to
e00e1a2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
makeRuntime+ facade exports fromfile/index.tsandfile/ripgrep.tsdebug/file.ts,debug/ripgrep.ts,test/file/ripgrep.test.ts) toAppRuntime.runPromisewithService.usedebug/file.tshandlers: remove unnecessaryEffect.genwrappers, add missingbootstrap()toFileTreeCommandService.useinstead ofEffect.gen+yield*boilerplatePart of the residual
makeRuntimecleanup tracked inspecs/effect/facades.md.