fix(opencode): remove double normalization in terminal background detection#22616
Open
lucoffe wants to merge 1 commit intoanomalyco:devfrom
Open
fix(opencode): remove double normalization in terminal background detection#22616lucoffe wants to merge 1 commit intoanomalyco:devfrom
lucoffe wants to merge 1 commit intoanomalyco:devfrom
Conversation
RGBA.fromInts() already normalizes r/g/b to 0.0-1.0 range, so dividing by 255 again in mode() made the luminance near-zero for any input. This caused getTerminalBackgroundColor() to always return "dark", breaking light variant selection for all dual-variant themes. Fixes anomalyco#22615 Related: anomalyco#20926
github-actions
bot
added
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
lucoffe
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #22615
Type of change
What does this PR do?
RGBA.fromInts()normalizes r/g/b to the 0.0–1.0 range internally. Themode()helper interminal.tsdivides by 255 on top of that — a leftover from the pre-#22297 code where the values were raw 0–255 integers. This double division caps max luminance at ~0.004 (for pure white), sogetTerminalBackgroundColor()always returns"dark".The fix removes the
/ 255. Related: #20926 (the inverse bug — stuck on light — that #22297 was trying to fix).How did you verify your code works?
Read the
RGBAsource in@opentui/coreand confirmedfromIntsdivides by 255 and the.r/.g/.bgetters return 0.0–1.0 floats. With the/ 255removed, the luminance formula produces values in the correct 0.0–1.0 range and the 0.5 threshold works as intended.Screenshots / recordings
N/A — terminal color detection, no UI change.
Checklist