Skip to content

fix: correctly find max satisfying version from unsorted arrays #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
leny-mi wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: correctly find max satisfying version from unsorted arrays #217

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6c4e8f5
fix: correctly find max satisfying version from unsorted arrays
leny-mi Sep 30, 2025
7ec2727
test: integrate unsorted version test into main getMaxSatisfying test
leny-mi Oct 1, 2025
a2ec446
fix: handle unsorted versions in newest mode
leny-mi Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions src/utils/versions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,13 +64,16 @@ export function getPrefixedVersion(current: string, target: string) {
}

export function getMaxSatisfying(versions: string[], current: string, mode: RangeMode, tags: Record<string, string>): string | undefined {
let version = null
let version: string | null = null

if (mode === 'latest') {
version = tags.latest
}
else if (mode === 'newest') {
version = versions[versions.length - 1]
versions.forEach((ver) => {
if (!version || semver.gt(ver, version))
version = ver
})
}
else if (mode === 'next') {
version = tags.next
Expand All @@ -88,10 +91,8 @@ export function getMaxSatisfying(versions: string[], current: string, mode: Rang
maxVersion = null

versions.forEach((ver) => {
if (semver.satisfies(ver, range)) {
if (!maxVersion || semver.lte(ver, maxVersion))
version = ver
}
if (semver.satisfies(ver, range) && (!maxVersion || semver.lte(ver, maxVersion)) && (!version || semver.gt(ver, version)))
version = ver
})
}

Expand Down
16 changes: 16 additions & 0 deletions test/versions.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,22 @@ it('getMaxSatisfying', async () => {
rc: '4.2.1-rc.3',
experimental: '0.0.0-experimental-4508873393-20240430',
}))

// should handle unsorted version arrays
// fixes bug where Object.keys() returns versions in arbitrary order
expect('2.8.1').toBe(getMaxSatisfying([
'1.0.0',
'2.8.0',
'2.8.1',
'2.4.5',
'2.4.0',
'2.4.1', // This appears after 2.8.1 in the array
], '^2.0.0', 'default', {
latest: '2.8.1',
}))

// newest mode should return the actual newest version, not the last in array
expect('3.0.0').toBe(getMaxSatisfying(['1.0.0', '3.0.0', '2.0.0'], '', 'newest', {}))
}, 10_000)

it('deprecated filter', () => {
Expand Down