refactor: replace tinyglobby dependency#226
Open
danielbayley wants to merge 1 commit intoantfu-collective:mainfrom
Open
refactor: replace tinyglobby dependency#226danielbayley wants to merge 1 commit intoantfu-collective:mainfrom
danielbayley wants to merge 1 commit intoantfu-collective:mainfrom
Conversation
Member
|
From the docs here https://nodejs.org/api/fs.html#fspromisesglobpattern-options will require Node 22, this is breaking, what happens with Node 20 support? |
userquin
reviewed
Nov 2, 2025
| exclude: DEFAULT_IGNORE_PATHS.concat(options.ignorePaths || []), | ||
| cwd, | ||
| withFileTypes: true, | ||
| })) |
Member
There was a problem hiding this comment.
cannot be done with await Promise.all or move it to async generator (to be consumed via for await loop)? this way we can also apply the filter in the async function*
Member
There was a problem hiding this comment.
iirc we also have a PR at fsdir to add aynsc generator support (being used by tinyglobby)
Member
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaces unnecessary dependency on
tinyglobbywith built-in Nodefs.promises.glob.