Skip to content

Conversation

@ndellosa95
Copy link

@ndellosa95 ndellosa95 commented Jan 12, 2026

Closes #60172

Wanted to get feedback on this before I go ahead and make this production ready. My approach here is to simply hold the TaskState message in the case of retries until after the retry callback runs. However, I'm wondering if it may be preferable to create a new message type (I didn't see an existing one that can do this) that can allow amendments to task state for tasks that are not currently running. Additionally, this also kind of hacks a special code path for retry callbacks that maybe should be generalized - right now it's going to send the TaskState message twice unless it's a retry, which will obviously need to be amended.

Was generative AI tooling used to co-author this PR?

  • Yes (please specify the tool below)

Generated-by: Cursor following the guidelines.

I use Cursor for the tab and ask features but the actual code is authored by me.


  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg
Copy link

boring-cyborg bot commented Jan 12, 2026

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix handling AirflowFailException on_retry_callback

1 participant