Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #60172
Wanted to get feedback on this before I go ahead and make this production ready. My approach here is to simply hold the
TaskStatemessage in the case of retries until after the retry callback runs. However, I'm wondering if it may be preferable to create a new message type (I didn't see an existing one that can do this) that can allow amendments to task state for tasks that are not currently running. Additionally, this also kind of hacks a special code path for retry callbacks that maybe should be generalized - right now it's going to send theTaskStatemessage twice unless it's a retry, which will obviously need to be amended.Was generative AI tooling used to co-author this PR?
Generated-by: Cursor following the guidelines.
I use Cursor for the tab and ask features but the actual code is authored by me.
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.