Skip to content

Conversation

@Vamsi-klu
Copy link

@Vamsi-klu Vamsi-klu commented Jan 12, 2026

Why

The Execution API spec lacks OpenAPI metadata for the RTIF endpoint, which makes client generation and discovery harder. This change documents the endpoint; runtime behavior is unchanged.

Tests

Not run (metadata-only change).

Follow-ups

@Vamsi-klu
Copy link
Author

Utilized claude code to generate the test and PR details. Open for feedback!

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please split those issues into separate issue per todo and make a description actually readable? We do not neeed those tables and a lot of "noise" generated by claude code. ideally description should describe the gist of a "single" change.

Hopefully the description should be way shorter and easier to read than the code, and it should not describe what was done but why. What is done is visible in the change.

Comment on lines 144 to 146
# Used by dot_renderer.py for DAG graph visualization and exposed in the API
ui_color: str = "#fff"
ui_fgcolor: str = "#000"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They shouldn't be -- we want to remove these

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback @ashb and @potiuk , i am working on the comments and will raise a revision at earliest

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for calling this out. I removed that change from this PR and tracked the removal in #60465 so it can be handled separately.

@Vamsi-klu Vamsi-klu force-pushed the fix-medium-priority-todos branch from 14c3e2f to 1711ec4 Compare January 13, 2026 21:20
@Vamsi-klu Vamsi-klu changed the title Add OpenAPI metadata for RTIF endpoint Execution API: document RTIF endpoint Jan 13, 2026
@Vamsi-klu Vamsi-klu marked this pull request as draft January 13, 2026 21:22
@Vamsi-klu
Copy link
Author

Scoped this PR to a single change (RTIF OpenAPI metadata) and moved the other TODOs into separate issues: #60463, #60464, #60465, #60466, #60467. The branch was force-updated and the PR is now draft for re-review.

@Vamsi-klu
Copy link
Author

@potiuk thanks for the feedback. I split the TODOs into separate issues and tightened the PR description to focus on the why; this PR now only documents RTIF OpenAPI metadata (no behavior change).\n\n@ashb the ui_color/ui_fgcolor removal is now tracked in #60465; no change in this PR.

@Vamsi-klu Vamsi-klu marked this pull request as ready for review January 14, 2026 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:API Airflow's REST/HTTP API area:CLI area:Executors-core LocalExecutor & SequentialExecutor area:serialization

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants