-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Execution API: document RTIF endpoint #60435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Utilized claude code to generate the test and PR details. Open for feedback! |
potiuk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please split those issues into separate issue per todo and make a description actually readable? We do not neeed those tables and a lot of "noise" generated by claude code. ideally description should describe the gist of a "single" change.
Hopefully the description should be way shorter and easier to read than the code, and it should not describe what was done but why. What is done is visible in the change.
| # Used by dot_renderer.py for DAG graph visualization and exposed in the API | ||
| ui_color: str = "#fff" | ||
| ui_fgcolor: str = "#000" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They shouldn't be -- we want to remove these
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for calling this out. I removed that change from this PR and tracked the removal in #60465 so it can be handled separately.
14c3e2f to
1711ec4
Compare
Why
The Execution API spec lacks OpenAPI metadata for the RTIF endpoint, which makes client generation and discovery harder. This change documents the endpoint; runtime behavior is unchanged.
Tests
Not run (metadata-only change).
Follow-ups