Skip to content

Conversation

@jscheffl
Copy link
Contributor

Was generative AI tooling used to co-author this PR?

  • No (please specify the tool below)

...at least as long as Breeze is not using AI to support maintainers :-D

@jscheffl
Copy link
Contributor Author

@eladkal or @potiuk need some providers managers power knowledge - some providers I have marked with "Not docs only" and then the other fixes were hidden from classification such that docs only update is made. Others marked with docs only ( because of year change in NOTICE) were docs only but not rendered changelogs... for consistency do I need to make all providers with NOTICE changes being a release (forced) to distribute or shall I downgrade the "docs only" releases to the same that are just for NOTICE?

@jscheffl jscheffl added the skip common compat check Skips common compat provider modification check label Jan 13, 2026
@jscheffl jscheffl closed this Jan 13, 2026
@jscheffl jscheffl reopened this Jan 13, 2026
@jscheffl jscheffl closed this Jan 13, 2026
@jscheffl jscheffl reopened this Jan 13, 2026
Copy link
Contributor

@dheerajturaga dheerajturaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified changes to edge3 and celery. Test failure was unrelated hence I attempted to rerun.

@potiuk
Copy link
Member

potiuk commented Jan 13, 2026

@eladkal or @potiuk need some providers managers power knowledge - some providers I have marked with "Not docs only" and then the other fixes were hidden from classification such that docs only update is made. Others marked with docs only ( because of year change in NOTICE) were docs only but not rendered changelogs... for consistency do I need to make all providers with NOTICE changes being a release (forced) to distribute or shall I downgrade the "docs only" releases to the same that are just for NOTICE?

Sorry for late notice - I was away and disconnected last few days - and I am now struck with cold and trying to catch up :)

Not sure if I understand :) -> but let me rephrase and see if I got it right:

  • when you selected "docs-only" -> the hash commit of the docs changed and no changelog was modified, no release is going to happen (so far so good)
  • when you selected not docs only and hid the others, there is a release (patchlevel) but it has "Docs-only" section in changelog

Correct?

If so - that's an interesting question - but I think the problem is that NOTICE change is not doc-only - it's a misc change - i.e. this change is actually going to change the released distribution (it will have updated NOTICE in metadata.

"Doc-only" changes are changes that only impact generated documentation - not the released package. In this case NOTICE change actually changes the released distribution so we should make it Misc.

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. Sorry for doing that, but I think we should release literally all providers now - the NOTICE change is not really a "doc-only" change - it's a change that affects released distributions (NOTICE is part of meta-data) and I think "all" providers should be rleeased.

@jscheffl jscheffl force-pushed the prepare-providers-release-2026-01-13 branch from 6542cbf to be92c96 Compare January 13, 2026 21:09
@jscheffl jscheffl requested a review from potiuk January 13, 2026 21:10
@jscheffl
Copy link
Contributor Author

Verified changes to edge3 and celery. Test failure was unrelated hence I attempted to rerun.

That was a bit too early. I need to officially cut the release (not the docs only) and then will call for VOTE for testing!

@jscheffl
Copy link
Contributor Author

@potiuk ditched previous work and re-generated ALL from scratch - second pass review please!

@jscheffl jscheffl merged commit acffa62 into apache:main Jan 13, 2026
130 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants