AIP-67 - Multi Team: Validate that global executors come before team executors in config #60438
+42
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add validation to ensure global executors are specified before any team executors, since we do not want them to be the default global executor.
o-nikolas
requested review from
XD-DENG,
ashb,
hussein-awala and
pierrejeambrun
as code owners
boring-cyborg
bot
added
the
area:Executors-core
eladkal
approved these changes
Jan 13, 2026
vincbeck
reviewed
Jan 13, 2026
Comment on lines
+255
to
+259
| if team_name is not None: | ||
| seen_team_executor = True | ||
| elif seen_team_executor: | ||
| # Found a global executor after we've already seen a team executor | ||
| raise AirflowConfigException( |
Contributor
There was a problem hiding this comment.
Why setting a boolean and then raising an exception if that flag is True (but in a different loop iteration)? So if there is one executor configured and this executor is team based, it will not raise an exception?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add validation to ensure global executors are specified before any team executors, since we do not want them to be the default global executor.
Was generative AI tooling used to co-author this PR?
Cline
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.