Add note support to triggerdagrunOperator with tests #60442
Closed
+60
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I added a small Airflow 2–specific unit test to ensure the note is handled correctly in the AF2 execution path, since the trigger flow differs from AF3. If maintainers feel the AF2 test or any part of the implementation is unnecessary or should be handled differently, I’m very happy to adjust or simplify it based on feedback. Looking forward to your review |
Member
There was a problem hiding this comment.
This PR is a duplicate of #60407 (most comments there holds for here). I would recommend closing this one.
Comment on lines
+289
to
+290
| if self.note: | ||
| self.log.info("Triggered DAG with note: %s", self.note) |
Member
There was a problem hiding this comment.
I don't think we can ever reach that? Having a note passed down in AF2, can we?
Member
|
Closing, same reason as: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was generative AI tooling used to co-author this PR?
Generated-by: ChatGPT following the guidelines
This PR adds support for passing a
notetoTriggerDagRunOperator, allowing users to attach contextual information when triggering DAG runs directly from the operator.What is changed
noteparameter toTriggerDagRunOperatorDagRunTriggerExceptionnoteparameterWhy this is needed
Currently, adding a note to a triggered DAG run is only possible via the API. This change enables users to pass notes directly from
TriggerDagRunOperator, improving usability and reducing the need for additional API calls or custom logic.Tests
TestDagRunOperator(Airflow 3)TestDagRunOperatorAF2(Airflow 2)pytestand BreezeDocumentation
noteparameterrelated: #56543