GH-49435: [CI][C++] Fix macOS build with Homebrew protobuf v34

.github/workflows/cpp.yml

@@ -230,6 +230,15 @@ jobs:
           brew uninstall pkg-config || :
           brew uninstall pkg-config@0.29.2 || :
           brew bundle --file=cpp/Brewfile
+
+          # protobuf@33 is keg-only, so make it visible to CMake and pkg-config.
+          # Remove this workaround after the gRPC problem is fixed.
+          # See https://github.com/grpc/grpc/issues/41755
+          export PROTOBUF_PREFIX="$(brew --prefix protobuf@33)"
+          echo "PKG_CONFIG_PATH=${PROTOBUF_PREFIX}/lib/pkgconfig:${PKG_CONFIG_PATH}" >> "$GITHUB_ENV"
+          echo "CMAKE_PREFIX_PATH=${PROTOBUF_PREFIX}:${ARROW_HOME}:${CMAKE_PREFIX_PATH}" >> "$GITHUB_ENV"
+          echo "${PROTOBUF_PREFIX}/bin" >> "$GITHUB_PATH"
+
       - name: Install MinIO
         run: |
           $(brew --prefix bash)/bin/bash \

.github/workflows/python.yml

@@ -201,6 +201,14 @@ jobs:
           brew uninstall pkg-config@0.29.2 || :
           brew bundle --file=cpp/Brewfile
 
+          # protobuf@33 is keg-only, so make it visible to CMake and pkg-config.
+          # Remove this workaround after the gRPC problem is fixed.
+          # See https://github.com/grpc/grpc/issues/41755
+          export PROTOBUF_PREFIX="$(brew --prefix protobuf@33)"
+          echo "PKG_CONFIG_PATH=${PROTOBUF_PREFIX}/lib/pkgconfig:${PKG_CONFIG_PATH}" >> "$GITHUB_ENV"
+          echo "CMAKE_PREFIX_PATH=${PROTOBUF_PREFIX}:${ARROW_HOME}:${CMAKE_PREFIX_PATH}" >> "$GITHUB_ENV"
+          echo "${PROTOBUF_PREFIX}/bin" >> "$GITHUB_PATH"
+
           python -m pip install \
             -r python/requirements-build.txt \
             -r python/requirements-test.txt

.github/workflows/ruby.yml

@@ -162,6 +162,7 @@ jobs:
           brew update
           brew bundle --file=cpp/Brewfile
           brew bundle --file=c_glib/Brewfile
+
           # For Meson.
           # See also: https://github.com/mesonbuild/meson/issues/7701
           echo "PKG_CONFIG=$(brew --prefix pkgconf)/bin/pkgconf" >> $GITHUB_ENV

cpp/Brewfile

@@ -36,7 +36,7 @@ brew "ninja"
 brew "node"
 brew "openssl"
 brew "pkgconf"
-brew "protobuf"
+brew "protobuf@33"
 brew "python"
 brew "rapidjson"
 brew "re2"

cpp/src/arrow/flight/sql/server.cc

@@ -537,7 +537,13 @@ arrow::Result<std::string> CreateStatementQueryTicket(
   ticket_statement_query.set_statement_handle(statement_handle);
 
   google::protobuf::Any ticket;
+#if PROTOBUF_VERSION >= 3015000
+  if (!ticket.PackFrom(ticket_statement_query)) {
+    return Status::IOError("Failed to pack ticket");
+  }
+#else
   ticket.PackFrom(ticket_statement_query);
+#endif
 
   std::string ticket_string;
 

cpp/src/arrow/flight/transport/grpc/serialization_internal.cc

@@ -353,7 +353,10 @@ ::grpc::Status FlightDataDeserialize(ByteBuffer* buffer,
         // Can't use ParseFromCodedStream as this reads the entire
         // rest of the stream into the descriptor command field.
         std::string buffer;
-        pb_stream.ReadString(&buffer, length);
+        if (!pb_stream.ReadString(&buffer, length)) {
+          return {::grpc::StatusCode::INTERNAL,
+                  "Unable to read FlightDescriptor from protobuf"};
+        }
         if (!pb_descriptor.ParseFromString(buffer)) {
           return {::grpc::StatusCode::INTERNAL, "Unable to parse FlightDescriptor"};
         }