Skip to content

Clean up unnecessary Python version check, remove old typing types from internal directory#38331

Closed
jrmccluskey wants to merge 1 commit intoapache:masterfrom
jrmccluskey:internalCleanup
Closed

Clean up unnecessary Python version check, remove old typing types from internal directory#38331
jrmccluskey wants to merge 1 commit intoapache:masterfrom
jrmccluskey:internalCleanup

Conversation

@jrmccluskey
Copy link
Copy Markdown
Contributor

Remove an effective no-op Python version check, clean up references to pre-PEP 585 types in the python apache_beam/internal directory


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on cleaning up the internal codebase by removing redundant version checks and modernizing type annotations. By adopting PEP 585 standards, the code becomes more idiomatic and leverages native Python type support, improving maintainability and reducing reliance on the typing module for standard collection types.

Highlights

  • Python Version Check Cleanup: Removed an unnecessary Python version check in the dill pickler logic that was effectively a no-op.
  • PEP 585 Type Modernization: Updated internal modules to use built-in collection types (e.g., dict, list, tuple) instead of the deprecated typing module equivalents, in accordance with PEP 585.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates type annotations to use built-in generics (PEP 585) and removes a Python version check for a dill monkey-patch. The review feedback highlights significant compatibility regressions for Python 3.8, which is still supported by the project. Specifically, using built-in types like dict, tuple, and list as generics will cause runtime TypeErrors on Python 3.8 unless the 'from future import annotations' directive is added. Furthermore, removing the version check in dill_pickler.py is likely to cause failures on Python 3.8 and 3.9 due to incompatible code object constructor arguments.

Comment thread sdks/python/apache_beam/internal/dill_pickler.py
Comment thread sdks/python/apache_beam/internal/dill_pickler.py
Comment thread sdks/python/apache_beam/internal/metrics/metric.py
Comment thread sdks/python/apache_beam/internal/util.py
@jrmccluskey
Copy link
Copy Markdown
Contributor Author

The Gemini code review bot seems to think that Beam supports Python 3.8 and 3.9. I am also not particularly pleased that it is auto-reviewing code by default again.

@jrmccluskey
Copy link
Copy Markdown
Contributor Author

Going to do a bigger LLM-driven fix here, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant