Clean up unnecessary Python version check, remove old typing types from internal directory#38331
Clean up unnecessary Python version check, remove old typing types from internal directory#38331jrmccluskey wants to merge 1 commit intoapache:masterfrom
Conversation
…om internal directory
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on cleaning up the internal codebase by removing redundant version checks and modernizing type annotations. By adopting PEP 585 standards, the code becomes more idiomatic and leverages native Python type support, improving maintainability and reducing reliance on the typing module for standard collection types. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates type annotations to use built-in generics (PEP 585) and removes a Python version check for a dill monkey-patch. The review feedback highlights significant compatibility regressions for Python 3.8, which is still supported by the project. Specifically, using built-in types like dict, tuple, and list as generics will cause runtime TypeErrors on Python 3.8 unless the 'from future import annotations' directive is added. Furthermore, removing the version check in dill_pickler.py is likely to cause failures on Python 3.8 and 3.9 due to incompatible code object constructor arguments.
|
The Gemini code review bot seems to think that Beam supports Python 3.8 and 3.9. I am also not particularly pleased that it is auto-reviewing code by default again. |
|
Going to do a bigger LLM-driven fix here, closing |
Remove an effective no-op Python version check, clean up references to pre-PEP 585 types in the python apache_beam/internal directory
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.