fix(explain): render aggregate expressions correctly when CSE is applied #19753
+210
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
This PR changes physical EXPLAIN formatting. |
Member
Looks sweet, would you like to change some failed tests, then we can see the effect of the change? |
Author
|
@xudong963 Thanks! I see the failures are in sqllogictest / Substrait / benchmark checks, likely due to updated EXPLAIN output. |
## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes apache#123` indicates that this PR will close issue apache#123. --> - Closes apache#19720. ## Rationale for this change - Choosing LZO compression errors, I think it might never get supported so the best option moving forward is to remove it algother and update the docs. <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> ## What changes are included in this PR? - Removed LZO from parse_compression_string() function - Removed docs - Updated exptected test output <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> ## Are these changes tested? Yes <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> ## Are there any user-facing changes? User choosing LZO as compression will get a clear error message: ``` Unknown or unsupported parquet compression: lzo. Valid values are: uncompressed, snappy, gzip(level), brotli(level), lz4, zstd(level), and lz4_raw. ``` <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. -->
github-actions
bot
added
documentation
github-actions
bot
removed
documentation
This reverts commit a14a7a9.
xudong963
reviewed
Jan 14, 2026
| physical_plan | ||
| 01)ProjectionExec: expr=[count(Int64(1))@0 as count(*)] | ||
| 02)--AggregateExec: mode=Single, gby=[], aggr=[count(Int64(1))] | ||
| 02)--AggregateExec: mode=Single, gby=[], aggr=[count(1) as count(Int64(1))] |
Member
There was a problem hiding this comment.
This looks like redundant for me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
“Fix physical EXPLAIN output for AggregateExec when CSE is applied.”
Previously, aggregate expressions were displayed using internal CSE aliases
(e.g. __common_expr_n), hiding the original aggregate functions. This change
renders aggregates using human_display(), preserving the original expressions
in the physical plan output.
Before: aggr=[__common_expr_1]
After: aggr=[SUM(a)]