-
Notifications
You must be signed in to change notification settings - Fork 2k
Misc minor optimizations to query optimizer performance #21128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
eec93a2
f23a621
532b74e
9b9e4f5
e53a07f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -47,12 +47,12 @@ impl OptimizerRule for PushDownLimit { | |
| true | ||
| } | ||
|
|
||
| #[expect(clippy::only_used_in_recursion)] | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this is just wasteful, just a lint away.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As in you plan to remove it as a follow on PR? |
||
| fn rewrite( | ||
| &self, | ||
| plan: LogicalPlan, | ||
| config: &dyn OptimizerConfig, | ||
| ) -> Result<Transformed<LogicalPlan>> { | ||
| let _ = config.options(); | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. that is weird
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. to answer your question above, I think the lint has to stay here because this seems worse, and as far as I can tell in this rule the config is just passed along recursively |
||
| let LogicalPlan::Limit(mut limit) = plan else { | ||
| return Ok(Transformed::no(plan)); | ||
| }; | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
empty DFSchema isn't free, similar to #20534