Use separate tokio runtime for IO in datafusion-cli#21138
Draft
alamb wants to merge 2 commits intoapache:mainfrom
Draft
Use separate tokio runtime for IO in datafusion-cli#21138alamb wants to merge 2 commits intoapache:mainfrom
alamb wants to merge 2 commits intoapache:mainfrom
Conversation
Contributor
Author
|
This didn't seem to make a meaningful difference in performance -- I need to look more carefully at the io pattern |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
While profiling #20820 I noticed that datafusion-cli is still not keeping its CPU entirely busy for unclear reasons
One interesting thing I noted is that there is no separate IO threads, even though there should be.
I want to test and see if using a separate IO runtime makes a difference
What changes are included in this PR?
Add a separate IO runtime to datafusion-cli and ensure that all IO happens on that stream
Are these changes tested?
Are there any user-facing changes?