No cargo test for sort_mem_validation#21222
Merged
blaginin merged 1 commit intoapache:mainfrom Mar 29, 2026
Merged
Conversation
2010YOUY01
approved these changes
Mar 28, 2026
| .arg("extended_tests") | ||
| .arg("--") | ||
|
|
||
| let exe = std::env::current_exe().expect("Failed to get test binary path"); |
Member
Author
|
Extended tests results: https://github.com/apache/datafusion/actions/runs/23704001088 |
Member
Author
|
I think this runs 2-3 minutes faster then on develop (no need to recompile code twice) 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every time I run tests with
sort_mem_validationi'm forced to recompile those tests several times, as those triggercargo test(=recompilation with different features). I made it use the existing compiled binaryShould save us 2-3 minutes on recompiling code on CI