feat: fix AVG sliding windows wrong results with NULLs#22139
Open
comphead wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
AVGused as a window aggregate can returnNaN(and, forDecimal/Duration, panic on integer division by zero) when every value in the window frame is NULL.Root cause: sliding-window execution calls
Accumulator::retract_batchas rows leave the frame. Once every contributing value has been retracted,self.countdrops back to0butself.sumstaysSome(0.0)(or a tiny floating-point residual).evaluate()then computessum / 0, which yieldsNaNonFloat64, and would panic with integer division by zero onDecimalAvgAccumulatorandDurationAvgAccumulator.The non-sliding aggregation path is unaffected because there
sumbecomesSome(_)only after at least one non-NULL value has been added, socount == 0impliessum == None.What changes are included in this PR?
datafusion/functions-aggregate/src/average.rs— guard all three affectedevaluate()implementations with an explicitcount == 0 → Noneshort-circuit:AvgAccumulator::evaluate(Float64)DecimalAvgAccumulator::evaluate(Decimal32/64/128/256)DurationAvgAccumulator::evaluate(Duration*)This matches the idiom already used by sibling retractable accumulators (
variance.rsuses an explicitmatch self.countbefore division;sum.rsuses a(self.count != 0).then_some(..)guard).