Skip to content

[improvement](cloud) Propagate compute group id to BE thrift payloads#62487

Open
deardeng wants to merge 1 commit intoapache:masterfrom
deardeng:change-thrift
Open

[improvement](cloud) Propagate compute group id to BE thrift payloads#62487
deardeng wants to merge 1 commit intoapache:masterfrom
deardeng:change-thrift

Conversation

@deardeng
Copy link
Copy Markdown
Collaborator

What problem does this PR solve?

Issue Number: N/A

Related PR: None

Problem Summary: Add cloud_compute_group_id to cloud-to-BE related thrift structs so the compute group id can be propagated through heartbeat, warm up cache, and replica metadata payloads.

Release note

None

Check List (For Author)

  • Test: No need to test (thrift schema update only; no runtime logic changes in this commit)
  • Behavior changed: Yes (thrift payloads can now carry cloud_compute_group_id to BE)
  • Does this need documentation: No

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

### What problem does this PR solve?

Issue Number: N/A

Related PR: None

Problem Summary: Add cloud_compute_group_id to cloud-to-BE related thrift structs so the compute group id can be propagated through heartbeat, warm up cache, and replica metadata payloads.

### Release note

None

### Check List (For Author)

- Test: No need to test (thrift schema update only; no runtime logic changes in this commit)
- Behavior changed: Yes (thrift payloads can now carry cloud_compute_group_id to BE)
- Does this need documentation: No
@Thearas
Copy link
Copy Markdown
Contributor

Thearas commented Apr 14, 2026

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@deardeng
Copy link
Copy Markdown
Collaborator Author

run buildall

@hello-stephen
Copy link
Copy Markdown
Contributor

Cloud UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 78.48% (1798/2291)
Line Coverage 64.09% (32268/50345)
Region Coverage 65.07% (16246/24967)
Branch Coverage 55.61% (8687/15620)

@hello-stephen
Copy link
Copy Markdown
Contributor

FE Regression Coverage Report

Increment line coverage 0.00% (0/63) 🎉
Increment coverage report
Complete coverage report

@hello-stephen
Copy link
Copy Markdown
Contributor

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 53.03% (20135/37969)
Line Coverage 36.59% (189402/517680)
Region Coverage 32.83% (146991/447716)
Branch Coverage 33.98% (64365/189421)

@hello-stephen
Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100% (0/0) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 73.51% (27334/37183)
Line Coverage 57.20% (295226/516096)
Region Coverage 54.40% (245794/451848)
Branch Coverage 56.09% (106576/190003)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants