Skip to content

fix(graph): zooming a Force Graph with layoutAnimation false breaks edges#20517

Open
sz-p wants to merge 2 commits intoapache:masterfrom
sz-p:fix-20515
Open

fix(graph): zooming a Force Graph with layoutAnimation false breaks edges#20517
sz-p wants to merge 2 commits intoapache:masterfrom
sz-p:fix-20515

Conversation

@sz-p
Copy link
Contributor

@sz-p sz-p commented Nov 14, 2024

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Fixed issues

#20515

Details

Before: What was the problem?

image

After: How does it behave after the fixing?

下载

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Nov 14, 2024

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

@sz-p
Copy link
Contributor Author

sz-p commented Nov 14, 2024

I discovered the issue is in https://github.com/apache/echarts/blob/master/src/chart/graph/GraphView.ts#L281

it just update the links not both nodes and links.

It will be fixed when remove the update or update both nodes and links.

I'm not sure the update is necessary?

I have removed this update and It look work will.

If update both nodes and links the graph will have a large layout change when zoom happens again.

@sz-p
Copy link
Contributor Author

sz-p commented Mar 11, 2026

Conflicts resolved.
Can you help me review it @100pah (I noticed that you changed the GraphView.ts file) ^-^

@github-actions
Copy link
Contributor

The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-20517@4b07cd3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant