Add tests for Partition Spec Evolution#2479
Merged
Merged
Conversation
gabeiglio
reviewed
Sep 21, 2025
Contributor
|
Looks like this caught a bug! Thanks @gabeiglio for fixing it in #2489. Could you try to rebase this PR? |
rambleraptor
force-pushed
the
partition_sort_evolution_tests
branch
from
1306663 to
c29c29c
Compare
Collaborator
Author
|
@kevinjqliu rebased! |
kevinjqliu
approved these changes
Sep 23, 2025
kevinjqliu
left a comment
kevinjqliu
left a comment
Contributor
There was a problem hiding this comment.
LGTM
a few nit comments. Thanks for adding these tests :)
the add then remove one was a surprise to me
gabeiglio
reviewed
Sep 24, 2025
rambleraptor
force-pushed
the
partition_sort_evolution_tests
branch
2 times, most recently
from
b7410ef to
9384139
Compare
Contributor
|
@rambleraptor Thanks for adding this, can you fix the merge conflicts? |
rambleraptor
force-pushed
the
partition_sort_evolution_tests
branch
from
9384139 to
544e9be
Compare
Collaborator
Author
|
@Fokko merge conflicts fixed! |
Fokko
approved these changes
Oct 22, 2025
Fokko
left a comment
Fokko
left a comment
Contributor
There was a problem hiding this comment.
Thanks @rambleraptor and thanks for the review @kevinjqliu
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The Java implementation has several tests around updating Table Specs. This adds three of them to the Python Catalog Tests.
Are these changes tested?
Tests should pass.
Are there any user-facing changes?
Just tests.