fix: properly reset mock in test_hive_wait_for_lock#3047
Closed
sumedhsakdeo wants to merge 1 commit into
Closed
Conversation
Setting `mock.call_count = 0` does not actually reset the mock's internal call tracking, causing the second assertion to see accumulated calls from both test phases. Use `reset_mock()` instead. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
@sumedhsakdeo Thanks for raising this PR. Can you share the issue that you're seeing? It looks like the CI is working fine |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_hive_wait_for_locktest by usingreset_mock()instead of manually settingcall_count = 0mock.call_count = 0does not reset the mock's internal call tracking, causing the second assertion to see accumulated calls from both test phases (expected 5, got 8)Test plan
test_hive_wait_for_lockpasses consistently across all Python versions in CI