Skip to content

fix:update config during table refresh#3327

Merged
kevinjqliu merged 1 commit intoapache:mainfrom
yingjianwu98:fix/table-refresh-config
May 6, 2026
Merged

fix:update config during table refresh#3327
kevinjqliu merged 1 commit intoapache:mainfrom
yingjianwu98:fix/table-refresh-config

Conversation

@yingjianwu98
Copy link
Copy Markdown
Contributor

@yingjianwu98 yingjianwu98 commented May 6, 2026

Rationale for this change

Table.refresh() was not updating self.config from the refreshed TableResponse. The config field contains out of date, server-generated properties such as per-table access tokens (token) and credential refresh endpoints(client.refresh-credentials-endpoint).

Are these changes tested?

Yes, with a new test.

Are there any user-facing changes?

No

@yingjianwu98 yingjianwu98 changed the title update config during table refresh fix:update config during table refresh May 6, 2026
Copy link
Copy Markdown
Contributor

@gabeiglio gabeiglio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good catch, we didn't see any issues before with access tokens as the fresh.config was being correctly propagated to the table's fileio

Copy link
Copy Markdown
Contributor

@kevinjqliu kevinjqliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

nice catch! now this matches the Table object's fields

class Table:
"""An Iceberg table."""
_identifier: Identifier = Field()
metadata: TableMetadata
metadata_location: str = Field()
io: FileIO
catalog: Catalog
config: dict[str, str]
def __init__(

@kevinjqliu kevinjqliu merged commit 0f10a97 into apache:main May 6, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants