SPEC: backfill schemas from BaseUpdate to TableUpdate anyOf #14957
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
reviewed
Jan 4, 2026
open-api/rest-catalog-open-api.yaml
Outdated
| - $ref: '#/components/schemas/SetPropertiesUpdate' | ||
| - $ref: '#/components/schemas/RemovePropertiesUpdate' | ||
| - $ref: '#/components/schemas/AddViewVersionUpdate' | ||
| - $ref: '#/components/schemas/SetCurrentViewVersionUpdate' |
Contributor
There was a problem hiding this comment.
These two entries already exist in ViewUpdate. Why should we add them to TableUpdate?
Author
There was a problem hiding this comment.
Thanks for the catch, they shouldn't be copied over.
| - $ref: '#/components/schemas/SetStatisticsUpdate' | ||
| - $ref: '#/components/schemas/RemoveStatisticsUpdate' | ||
| - $ref: '#/components/schemas/SetPartitionStatisticsUpdate' | ||
| - $ref: '#/components/schemas/RemovePartitionStatisticsUpdate' |
feefs
force-pushed
the
main
branch
2 times, most recently
from
8e1b014 to
ef3a35f
Compare
Author
|
@ebyhr friendly bump, I've rebased on top of the latest changes. |
ebyhr
approved these changes
Jan 10, 2026
Contributor
ebyhr
left a comment
ebyhr
left a comment
There was a problem hiding this comment.
Looks good to me.
@Fokko @singhpk234 @huaxingao Could you review this PR when you have time?
singhpk234
approved these changes
Jan 10, 2026
Contributor
singhpk234
left a comment
singhpk234
left a comment
There was a problem hiding this comment.
LGTM, i think its a miss mostly since java client supports it in ser-de, vote should not be required.
Lets see what others have to say !
huaxingao
approved these changes
Jan 11, 2026
Author
|
@ebyhr @singhpk234 @huaxingao @Fokko another friendly bump, are the current approvals sufficient for merging? |
feefs
changed the title
feefs
force-pushed
the
main
branch
2 times, most recently
from
9310150 to
9aae4c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this should be a follow-up to #9690 (
set-partition-statisticsandremove-partition-statisticswere added toBaseUpdate'sdiscriminator:YAML sequence but notTableUpdate'sanyOf:YAML sequence) and #9240 (original refactor fromenum:todiscriminator:).Without this, the JSON Schema I'm generating for my validator is incorrectly rejecting
CommitTableRequestpayloads with TableUpdate schema objects such asset-partition-statistics.Ran my changes through:
and everything passes.