IGNITE-27473: WALMode consistency check and tests #12614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DEADripER
changed the title
DEADripER
changed the title
wernerdv
reviewed
Jan 12, 2026
|
|
||
| DataStorageConfiguration dsCfg = ctx.config().getDataStorageConfiguration(); | ||
|
|
||
| if (dsCfg != null) { |
Contributor
There was a problem hiding this comment.
Remove curly braces for one line statement.
wernerdv
reviewed
Jan 12, 2026
|
|
||
| if (locWalMode != rmtWalMode) { | ||
| throw new IgniteCheckedException("WAL mode validation failed. " + | ||
| " Local node(locNodeAddrs=" + U.addressesAsString(locNode) + |
Contributor
There was a problem hiding this comment.
Required indent is 4-space characters, currently it is 8.
wernerdv
reviewed
Jan 12, 2026
| WALMode rmtWalMode = n.attribute(ATTR_WAL_MODE); | ||
|
|
||
| if (locWalMode != rmtWalMode) { | ||
| throw new IgniteCheckedException("WAL mode validation failed. " + |
Contributor
There was a problem hiding this comment.
I suggest making the error message consistent with existing ones, for example:
throw new IgniteCheckedException("Remote node has WAL mode different from local " +
"[locId8=" + U.id8(locNode.id()) + ", locWalMode=" + locWalMode +
", rmtId8=" + U.id8(n.id()) + ", rmtWalMode=" + rmtWalMode +
", rmtAddrs=" + U.addressesAsString(n) + ", rmtNode=" + U.toShortString(n) + "]");
wernerdv
reviewed
Jan 12, 2026
| /** | ||
| * Tests for WAL mode consistency validation when nodes join cluster. | ||
| */ | ||
| public class GridDiscoveryManagerWalModeConsistencyTest extends GridCommonAbstractTest { |
Contributor
There was a problem hiding this comment.
A test class needs to be added to the suite.
wernerdv
reviewed
Jan 12, 2026
| assertEquals(1, ignite0.cluster().nodes().size()); | ||
| } | ||
|
|
||
|
|
wernerdv
reviewed
Jan 12, 2026
| /** {@inheritDoc} */ | ||
| @Override protected IgniteConfiguration getConfiguration(String igniteInstanceName) throws Exception { | ||
| IgniteConfiguration cfg = super.getConfiguration(igniteInstanceName) | ||
| .setGridLogger(testLog); |
Contributor
There was a problem hiding this comment.
It can be placed in one line.
wernerdv
reviewed
Jan 12, 2026
| walMode = WALMode.FSYNC; | ||
|
|
||
| LogListener walModeErrorLsnr = LogListener.matches("WAL mode validation failed") | ||
| .andMatches("LOG_ONLY") |
Contributor
There was a problem hiding this comment.
Required indent is 4-space characters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
The Contribution Checklist
The description explains WHAT and WHY was made instead of HOW.
The following pattern must be used:
IGNITE-XXXX Change summarywhereXXXX- number of JIRA issue.(see the Maintainers list)
the
green visaattached to the JIRA ticket (see TC.Bot: Check PR)Notes
If you need any help, please email [email protected] or ask anу advice on http://asf.slack.com #ignite channel.