KAFKA-20304: Implement all required ReadOnly*Facade classes for headers stores#21743
Open
aliehsaeedii wants to merge 1 commit intoapache:trunkfrom
Open
KAFKA-20304: Implement all required ReadOnly*Facade classes for headers stores#21743aliehsaeedii wants to merge 1 commit intoapache:trunkfrom
aliehsaeedii wants to merge 1 commit intoapache:trunkfrom
Conversation
aliehsaeedii
commented
Mar 13, 2026
Contributor
Author
aliehsaeedii
left a comment
aliehsaeedii
left a comment
There was a problem hiding this comment.
I'm wondering if it makes sense to remove
- ReadOnlyKeyValueStoreFacadeTest (exists)
- ReadOnlyWindowStoreFacadeTest (exists)
- KeyValueIteratorFacadeTest (exists)
just to be consistent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
ReadOnly*Facadeclasses required to wrap headers store for backward compatibilityReadOnly*Facadeclasses to use generic infrastructure with converter functions