KAFKA-20308: Update TopologyTestDriver to support for headers-aware stores#21745
Merged
mjsax merged 2 commits intoapache:trunkfrom Mar 15, 2026
Merged
KAFKA-20308: Update TopologyTestDriver to support for headers-aware stores#21745mjsax merged 2 commits intoapache:trunkfrom
mjsax merged 2 commits intoapache:trunkfrom
Conversation
mjsax
reviewed
Mar 14, 2026
| } | ||
| } | ||
|
|
||
| static class ReadOnlyWindowStoreFacadeForHeaders<K, V> implements ReadOnlyWindowStore<K, V> { |
Member
There was a problem hiding this comment.
Seems this duplicate the class we add via #21743 ?
We should clean this up later.
Member
|
Overall this look good, but it might benefit from also follow the pattern from #21743 and use |
5916078 to
2b67faa
Compare
mjsax
approved these changes
Mar 15, 2026
gabriellefu
pushed a commit
to gabriellefu/kafka
that referenced
this pull request
Mar 30, 2026
…tores (apache#21745) This PR adds full TopologyTestDriver support for headers-aware state stores, enabling tests to both access headers and use the simple non-headers API automatically. Reviewers: Matthias J. Sax <matthias@confluent.io>
Shekharrajak
pushed a commit
to Shekharrajak/kafka
that referenced
this pull request
Mar 31, 2026
…tores (apache#21745) This PR adds full TopologyTestDriver support for headers-aware state stores, enabling tests to both access headers and use the simple non-headers API automatically. Reviewers: Matthias J. Sax <matthias@confluent.io>
nileshkumar3
pushed a commit
to nileshkumar3/kafka
that referenced
this pull request
Apr 15, 2026
…tores (apache#21745) This PR adds full TopologyTestDriver support for headers-aware state stores, enabling tests to both access headers and use the simple non-headers API automatically. Reviewers: Matthias J. Sax <matthias@confluent.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds full TopologyTestDriver support for headers-aware state
stores, enabling tests to both access headers and use the simple
non-headers API automatically.
Reviewers: Matthias J. Sax matthias@confluent.io