Optimize FieldExistsQuery.count() when all docs have the field#16111
Open
iprithv wants to merge 1 commit into
Open
Optimize FieldExistsQuery.count() when all docs have the field#16111iprithv wants to merge 1 commit into
iprithv wants to merge 1 commit into
Conversation
iprithv
force-pushed
the
optimize-fieldexists-count
branch
2 times, most recently
from
5ff0197 to
10b7760
Compare
Contributor
Author
|
@jpountz could you please help review this, thanks! |
iprithv
force-pushed
the
optimize-fieldexists-count
branch
from
10b7760 to
0ac5a3b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when all documents have the field and some are deleted, both vectors and doc values still fall back to
super.count(context), even though we could just returnreader.numDocs()directly. fixed it!