HDDS-15486 Remove excessive debug logging in BlockOutputStream and Bu…#10439
Open
yandrey321 wants to merge 2 commits into
Open
HDDS-15486 Remove excessive debug logging in BlockOutputStream and Bu…#10439yandrey321 wants to merge 2 commits into
yandrey321 wants to merge 2 commits into
Conversation
amaliujia
reviewed
Jun 5, 2026
| releaser.start(); | ||
| allocator.join(); | ||
| assertEquals(toRelease, allocated.get()); | ||
| assertTrue(logCapturer.getOutput().contains("Allocation needs to wait the pool is at capacity")); |
Contributor
There was a problem hiding this comment.
I think we are losing testing coverage if you remove this line.
We might be able to do the following above
assertTrue(pool.allocated.size() == pool.capacity)
allocated.set(pool.allocateBuffer(0));
However I am not completely sure.
To be safe, we can keep this type of verification. Other removals over LOG_DEBUG look ok.
Contributor
Author
There was a problem hiding this comment.
I'd avoid validation through log messages and prefer to do it via actual state check
Contributor
Author
There was a problem hiding this comment.
there is a check if pool is full at the beginning of the function:
assertFull(pool);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove excessive debug logging in BlockOutputStream and BufferPool
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-15486
How was this patch tested?
Unit tests