Skip to content

Conversation

@massucattoj
Copy link
Contributor

@massucattoj massucattoj commented Jan 15, 2026

SUMMARY

Refactors transformIntervalAnnotation and transformEventAnnotation in the ECharts Timeseries plugin to group annotations that share the same timestamp.

Problem: When multiple event or interval annotations had the same start time, each annotation created its own series, resulting in overlapping labels and visual clutter.

Solution: Annotations at the same timestamp are now combined into a single series with their labels joined by newlines. This produces cleaner rendering and better performance by reducing the number of series created.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE:
image

image

AFTER:
Screenshot 2026-01-15 at 06 51 31

Screenshot 2026-01-15 at 06 51 53

TESTING INSTRUCTIONS

  1. Create a table chart following the instructions here (you can use a Google Sheet for this). You can also use this Google sheet.
  2. Then, create a Line chart and add a new annotation layer on it
  3. After this, you select the Annotation Layer type, Interval or Event
  4. Then the annotation source Table
  5. As the next step, you select the table chart you created in step
  6. This reloads the annotation windows to show the specific options associated with the table
  7. Define the Interval start column/Event time column by using the start_date column that has the table chart
  8. Add the annotation by clicking on the Apply button

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codeant-ai-for-open-source
Copy link
Contributor

CodeAnt AI is reviewing your PR.


Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

@bito-code-review
Copy link
Contributor

bito-code-review bot commented Jan 15, 2026

Code Review Agent Run #3aa3c3

Actionable Suggestions - 0
Review Details
  • Files reviewed - 2 · Commit Range: d354592..d354592
    • superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformers.ts
    • superset-frontend/plugins/plugin-chart-echarts/test/utils/transformers.test.ts
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful
    • Eslint (Linter) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at [email protected].

Documentation & Help

AI Code Review powered by Bito Logo

@codeant-ai-for-open-source
Copy link
Contributor

CodeAnt AI finished reviewing your PR.

@netlify
Copy link

netlify bot commented Jan 15, 2026

Deploy Preview for superset-docs-preview ready!

Name Link
🔨 Latest commit d354592
🔍 Latest deploy log https://app.netlify.com/projects/superset-docs-preview/deploys/6968ba1e79dda50008288e5a
😎 Deploy Preview https://deploy-preview-37164--superset-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@massucattoj massucattoj changed the title fix(echarts-timeseries-combined-labels): combine annotation labels fo… fix(echarts-timeseries-combined-labels): combine annotation labels for events at same timestamp Jan 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant