Skip to content

Conversation

@dheeraj12347
Copy link

This fix adds sans-serif as a generic font fallback to ensure consistent
sans-serif rendering when preferred fonts (Inter, Helvetica, Arial) are not available.

Previously, when none of the specified fonts were available, browsers would default
to serif fonts, causing inconsistent visuals in dashboard reports and screenshots.

Changes:

  • Updated fontFamily in superset/config.py from "Inter, Helvetica, Arial" to "Inter, Helvetica, Arial, sans-serif"

Fixes #37096

@codeant-ai-for-open-source
Copy link
Contributor

CodeAnt AI is reviewing your PR.


Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

@bito-code-review
Copy link
Contributor

bito-code-review bot commented Jan 15, 2026

Code Review Agent Run #898a4c

Actionable Suggestions - 0
Review Details
  • Files reviewed - 1 · Commit Range: 81b471e..81b471e
    • superset/config.py
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful
    • MyPy (Static Code Analysis) - ✔︎ Successful
    • Astral Ruff (Static Code Analysis) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at [email protected].

Documentation & Help

AI Code Review powered by Bito Logo

@codeant-ai-for-open-source
Copy link
Contributor

CodeAnt AI finished reviewing your PR.

@netlify
Copy link

netlify bot commented Jan 15, 2026

Deploy Preview for superset-docs-preview ready!

Name Link
🔨 Latest commit 81b471e
🔍 Latest deploy log https://app.netlify.com/projects/superset-docs-preview/deploys/6969138863474600082ee2af
😎 Deploy Preview https://deploy-preview-37172--superset-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@dheeraj12347
Copy link
Author

This PR adds a generic sans-serif fallback to THEME_DEFAULT.fontFamily so if Inter/Helvetica/Arial are missing, the browser still uses a sans-serif font instead of a serif fallback. This keeps dashboards and screenshots visually consistent across environments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Font fallback should include sans-serif

1 participant