-
Notifications
You must be signed in to change notification settings - Fork 16.5k
fix: Move head_custom_extra above csrf token input #37173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
CodeAnt AI is reviewing your PR. Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
Code Review Agent Run #9663dfActionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help |
|
CodeAnt AI finished reviewing your PR. |
✅ Deploy Preview for superset-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #37173 +/- ##
===========================================
+ Coverage 0 67.87% +67.87%
===========================================
Files 0 642 +642
Lines 0 48057 +48057
Branches 0 5257 +5257
===========================================
+ Hits 0 32620 +32620
- Misses 0 14151 +14151
- Partials 0 1286 +1286
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
(cherry picked from commit ab8df1a)
SUMMARY
In some browsers
<input>is not a valid<head>element and browsers moves it, but also every other element in head below that input, to<body>. To prevent having the contents of head_custom_extra.html moved to body, we need to move it above the csrf_token input elementBEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION