Skip to content

Conversation

@kgabryje
Copy link
Member

@kgabryje kgabryje commented Jan 15, 2026

SUMMARY

In some browsers <input> is not a valid <head> element and browsers moves it, but also every other element in head below that input, to <body>. To prevent having the contents of head_custom_extra.html moved to body, we need to move it above the csrf_token input element

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codeant-ai-for-open-source
Copy link
Contributor

CodeAnt AI is reviewing your PR.


Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

@bito-code-review
Copy link
Contributor

bito-code-review bot commented Jan 15, 2026

Code Review Agent Run #9663df

Actionable Suggestions - 0
Review Details
  • Files reviewed - 1 · Commit Range: e8b0bfd..e8b0bfd
    • superset/templates/superset/spa.html
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at [email protected].

Documentation & Help

AI Code Review powered by Bito Logo

@dosubot dosubot bot added the change:frontend Requires changing the frontend label Jan 15, 2026
@codeant-ai-for-open-source
Copy link
Contributor

CodeAnt AI finished reviewing your PR.

@netlify
Copy link

netlify bot commented Jan 15, 2026

Deploy Preview for superset-docs-preview ready!

Name Link
🔨 Latest commit e8b0bfd
🔍 Latest deploy log https://app.netlify.com/projects/superset-docs-preview/deploys/69691523e836e4000742de58
😎 Deploy Preview https://deploy-preview-37173--superset-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link

codecov bot commented Jan 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.87%. Comparing base (23b91d2) to head (e8b0bfd).
⚠️ Report is 22 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #37173       +/-   ##
===========================================
+ Coverage        0   67.87%   +67.87%     
===========================================
  Files           0      642      +642     
  Lines           0    48057    +48057     
  Branches        0     5257     +5257     
===========================================
+ Hits            0    32620    +32620     
- Misses          0    14151    +14151     
- Partials        0     1286     +1286     
Flag Coverage Δ
hive 42.86% <ø> (?)
mysql 65.90% <ø> (?)
postgres 65.94% <ø> (?)
presto 46.43% <ø> (?)
python 67.84% <ø> (?)
sqlite 65.66% <ø> (?)
unit 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kgabryje kgabryje changed the title Move head_custom_extra above csrf token input fix: Move head_custom_extra above csrf token input Jan 15, 2026
@kgabryje kgabryje merged commit ab8df1a into apache:master Jan 16, 2026
78 of 83 checks passed
aminghadersohi pushed a commit to aminghadersohi/superset that referenced this pull request Jan 16, 2026
sadpandajoe pushed a commit that referenced this pull request Jan 16, 2026
@sadpandajoe sadpandajoe added the v6.0 Label added by the release manager to track PRs to be included in the 6.0 branch label Jan 16, 2026
reynoldmorel pushed a commit to reynoldmorel/superset that referenced this pull request Jan 16, 2026
JCelento pushed a commit to JCelento/superset that referenced this pull request Jan 19, 2026
JCelento pushed a commit to JCelento/superset that referenced this pull request Jan 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

change:frontend Requires changing the frontend size/XS v6.0 Label added by the release manager to track PRs to be included in the 6.0 branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants