fix: use BINARY type for RAW_BYTES URL fetcher schema#5133
Merged
Conversation
Contributor
Author
|
/request-review @aglinxinyuan |
Contributor
|
Can you provide a workflow JSON that I can test the difference before and after this change? |
Contributor
@Ma77Ball please provide a test JSON |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5133 +/- ##
============================================
- Coverage 43.34% 42.86% -0.49%
+ Complexity 2213 2210 -3
============================================
Files 1049 1045 -4
Lines 40561 40188 -373
Branches 4322 4251 -71
============================================
- Hits 17581 17226 -355
Misses 21888 21888
+ Partials 1092 1074 -18
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
@Ma77Ball can you make coverage happy? |
Contributor
Author
|
I added a test JSON file and improved code coverage. @Yicong-Huang, please review and merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
URLFetcherOpDesc.sourceSchema()advertisedAttributeType.ANYforRAW_BYTESdecoding, even though the executor already emits a concretebyte[]. This change returnsAttributeType.BINARYinstead, matching the runtime payload and unblocking Iceberg materialization (which rejectsANY). The existingURLFetcherOpDescSpectest that pinned the old behavior is flipped to assertBINARY.Test json:
url-fetcher-raw-bytes-test.json
Any related issues, documentation, or discussions?
Closes: #5074
How was this PR tested?
Updated
URLFetcherOpDescSpeccovers the schema;URLFetcherOpExecSpecalready pins the runtime field asArray[Byte], so static schema and runtime type now agree. CI Scala test job is expected to pass.Was this PR authored or co-authored using generative AI tooling?
Co-authored with Claude Opus 4.7 in compliance with ASF