THRIFT-5310: Harden Ruby binary protocol integer bounds#3502
Open
kpumuk wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Ruby binary protocol integer serialization so signed Thrift integer types are validated consistently before writing.
Previously, Ruby
BinaryProtocolcould silently wrap or clip out-of-range values, for example:write_byte(255)wrote0xff, which read back as-1write_i16(40000)succeededwrite_i64(2**63)succeededThis now rejects out-of-range values for
byte,i16,i32, andi64in both the pure Ruby and native accelerated binary protocol implementations. Container sizes and binary/string lengths are also checked before writing as non-negative signedi32lengths.Implementation Notes
BinaryProtocol.binary_protocol_accelerated.c."nil argument not allowed!"error.Integer#between?in the write hot path. A direct micro-benchmark showed:for 20M checks, so the final Ruby implementation uses direct comparisons.
Benchmark Results
Benchmarked serialization with
test/rb/benchmarks/protocol_benchmark.rb.Command:
Results:
No serialization regression was observed.
[skip ci]anywhere in the commit message to free up build resources.