Skip to content

test: Use rerun instead skip for flaky tests #1670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vdusek merged 1 commit into from
Jan 13, 2026
Merged

test: Use rerun instead skip for flaky tests #1670

vdusek merged 1 commit into from
Jan 13, 2026
+32 −15

Conversation

@Mantisus
Copy link
Collaborator

@Mantisus Mantisus commented Jan 12, 2026

Description

  • Perform 3 launch attempts for tests marked as flaky, instead of skipping them.

@Mantisus Mantisus self-assigned this Jan 12, 2026
@Mantisus Mantisus requested review from Pijukatel and vdusek January 12, 2026 19:59
@Pijukatel
Copy link
Collaborator

Pijukatel commented Jan 13, 2026

If used carefully, it can be ok. However, we should be cautious not to overuse it, as it can hide the real issues.

@vdusek vdusek changed the title chore: Use rerun instead skip for flaky tests test: Use rerun instead skip for flaky tests Jan 13, 2026
@vdusek vdusek merged commit bce2491 into apify:master Jan 13, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vdusek vdusek vdusek approved these changes

@Pijukatel Pijukatel Pijukatel approved these changes

Assignees

@Mantisus Mantisus

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Mantisus @Pijukatel @vdusek