Prevent bash option reversion commands in bash completion function from being appended to bash history#859
Merged
natecook1000 merged 1 commit intoapple:mainfrom Mar 20, 2026
Conversation
|
I don't understand bash as a language enough to comment on the code, but I can confirm issue #858 is resolved in this branch! |
Contributor
Author
|
The cancellations don't seem to be related to the code changes in this PR. |
Contributor
Author
|
Is there anything that I (or anyone else) must do to get the cancelled checks to run? The PR's change just adds in scripting to replace newlines with semicolons in the The change shouldn't have prevented the PR checks from running, so I assume the problem is in the check configuration. |
99f8599 to
e4be05a
Compare
…om being appended to bash history. Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
e4be05a to
34ba451
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent bash option reversion commands in bash completion function from being appended to bash history.
Resolve #858
Checklist