Skip to content

(chore): update static install compose#2865

Open
abnegate wants to merge 1 commit intomainfrom
fix-static-install
Open

(chore): update static install compose#2865
abnegate wants to merge 1 commit intomainfrom
fix-static-install

Conversation

@abnegate
Copy link
Copy Markdown
Member

@abnegate abnegate commented Apr 7, 2026

What does this PR do?

(Provide a description of what this PR does.)

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)

Related PRs and Issues

(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)

Have you read the Contributing Guidelines on issues?

(Write your answer here.)

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Apr 7, 2026

Greptile Summary

This PR is a maintenance upgrade of static/install/compose that bumps all Appwrite service images to 1.9.0, Traefik from 2.11 to 3.6 (major version), Console to 7.8.26, and Redis to 7.4.7. It also introduces proper health checks for MariaDB and Redis and upgrades all depends_on declarations to use condition: service_healthy — a meaningful reliability improvement.

Key issues:

  • _APP_DB_ADAPTER is duplicated in the environment: block of every service (appears twice per service across all 19 affected services) — a copy-paste error introduced in this PR
  • <<: *x-logging was removed from the mariadb service, making it the only infrastructure service without log rotation, which can lead to unbounded disk usage

Confidence Score: 4/5

Safe to merge after fixing the _APP_DB_ADAPTER duplicates and restoring log rotation to mariadb

Both issues are P2 style/consistency findings with no immediate runtime breakage. The _APP_DB_ADAPTER duplication is harmless since Docker Compose uses the last value, and the missing x-logging on mariadb is an ops consistency gap rather than a crash risk. However, given the scale of the duplication (19 services) and the logging gap, these are worth addressing before merging. Score is 4 rather than 5 because the duplication is widespread and easy to fix.

static/install/compose — _APP_DB_ADAPTER duplicated across all 19 service environment blocks, and mariadb is missing the <<: *x-logging anchor

Important Files Changed

Filename Overview
static/install/compose Version bumps (Appwrite 1.9.0, Traefik 3.6, Console 7.8.26, Redis 7.4.7), health checks added, depends_on upgraded to service_healthy — but _APP_DB_ADAPTER is duplicated in every service's env block, and <<: *x-logging was removed from mariadb

Reviews (1): Last reviewed commit: "(chore): update static install compose" | Re-trigger Greptile

Comment on lines +100 to +106
- _APP_DB_ADAPTER
- _APP_DB_HOST
- _APP_DB_PORT
- _APP_DB_SCHEMA
- _APP_DB_USER
- _APP_DB_PASS
- _APP_DB_ADAPTER
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 _APP_DB_ADAPTER duplicated in every service

_APP_DB_ADAPTER is listed twice in the environment: block of every service — once before _APP_DB_HOST and again after _APP_DB_PASS. This is a copy-paste error that affects all 19 services in the file.

The duplicate entries appear at these line pairs:

  • appwrite: lines 100, 106
  • appwrite-realtime: lines 236, 242
  • appwrite-worker-audits: lines 267, 273
  • appwrite-worker-webhooks: lines 295, 301
  • appwrite-worker-deletes: lines 336, 342
  • and in every other worker/scheduler/task service throughout the file (lines 396/402, 433/439, 509/515, 543/549, 581/587, 624/630, 685/691, 724/730, 757/763, 790/796, 822/828, 858/864, 887/893, 916/922)

Docker Compose silently handles duplicate environment variable entries using the last value, so this is harmless at runtime — but it adds noise and should be cleaned up. The second occurrence (after _APP_DB_PASS) should be removed from every service block.

Suggested change
- _APP_DB_ADAPTER
- _APP_DB_HOST
- _APP_DB_PORT
- _APP_DB_SCHEMA
- _APP_DB_USER
- _APP_DB_PASS
- _APP_DB_ADAPTER
- _APP_DB_ADAPTER
- _APP_DB_HOST
- _APP_DB_PORT
- _APP_DB_SCHEMA
- _APP_DB_USER
- _APP_DB_PASS

Comment on lines 994 to 998
mariadb:
image: mariadb:10.11 # fix issues when upgrading using: mysql_upgrade -u root -p
image: mariadb:10.11
container_name: appwrite-mariadb
<<: *x-logging
restart: unless-stopped
networks:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 mariadb missing *x-logging anchor

The <<: *x-logging merge key was removed from the mariadb service in this PR, making it the only infrastructure service in the stack without the JSON log driver configuration (max-file: 5, max-size: 10m). Without log rotation, MariaDB's container logs can grow unboundedly and potentially cause disk exhaustion in busy environments.

Unless there is a deliberate reason to treat MariaDB differently (e.g., relying on MariaDB's own internal log management), <<: *x-logging should be restored for consistency with every other service in the file.

Suggested change
mariadb:
image: mariadb:10.11 # fix issues when upgrading using: mysql_upgrade -u root -p
image: mariadb:10.11
container_name: appwrite-mariadb
<<: *x-logging
restart: unless-stopped
networks:
mariadb:
image: mariadb:10.11
container_name: appwrite-mariadb
<<: *x-logging
restart: unless-stopped
networks:
- appwrite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant