Conversation
Greptile SummaryThis PR is a maintenance upgrade of Key issues:
Confidence Score: 4/5Safe to merge after fixing the _APP_DB_ADAPTER duplicates and restoring log rotation to mariadb Both issues are P2 style/consistency findings with no immediate runtime breakage. The _APP_DB_ADAPTER duplication is harmless since Docker Compose uses the last value, and the missing x-logging on mariadb is an ops consistency gap rather than a crash risk. However, given the scale of the duplication (19 services) and the logging gap, these are worth addressing before merging. Score is 4 rather than 5 because the duplication is widespread and easy to fix. static/install/compose — _APP_DB_ADAPTER duplicated across all 19 service environment blocks, and mariadb is missing the <<: *x-logging anchor Important Files Changed
Reviews (1): Last reviewed commit: "(chore): update static install compose" | Re-trigger Greptile |
| - _APP_DB_ADAPTER | ||
| - _APP_DB_HOST | ||
| - _APP_DB_PORT | ||
| - _APP_DB_SCHEMA | ||
| - _APP_DB_USER | ||
| - _APP_DB_PASS | ||
| - _APP_DB_ADAPTER |
There was a problem hiding this comment.
_APP_DB_ADAPTER duplicated in every service
_APP_DB_ADAPTER is listed twice in the environment: block of every service — once before _APP_DB_HOST and again after _APP_DB_PASS. This is a copy-paste error that affects all 19 services in the file.
The duplicate entries appear at these line pairs:
appwrite: lines 100, 106appwrite-realtime: lines 236, 242appwrite-worker-audits: lines 267, 273appwrite-worker-webhooks: lines 295, 301appwrite-worker-deletes: lines 336, 342- and in every other worker/scheduler/task service throughout the file (lines 396/402, 433/439, 509/515, 543/549, 581/587, 624/630, 685/691, 724/730, 757/763, 790/796, 822/828, 858/864, 887/893, 916/922)
Docker Compose silently handles duplicate environment variable entries using the last value, so this is harmless at runtime — but it adds noise and should be cleaned up. The second occurrence (after _APP_DB_PASS) should be removed from every service block.
| - _APP_DB_ADAPTER | |
| - _APP_DB_HOST | |
| - _APP_DB_PORT | |
| - _APP_DB_SCHEMA | |
| - _APP_DB_USER | |
| - _APP_DB_PASS | |
| - _APP_DB_ADAPTER | |
| - _APP_DB_ADAPTER | |
| - _APP_DB_HOST | |
| - _APP_DB_PORT | |
| - _APP_DB_SCHEMA | |
| - _APP_DB_USER | |
| - _APP_DB_PASS |
| mariadb: | ||
| image: mariadb:10.11 # fix issues when upgrading using: mysql_upgrade -u root -p | ||
| image: mariadb:10.11 | ||
| container_name: appwrite-mariadb | ||
| <<: *x-logging | ||
| restart: unless-stopped | ||
| networks: |
There was a problem hiding this comment.
mariadb missing *x-logging anchor
The <<: *x-logging merge key was removed from the mariadb service in this PR, making it the only infrastructure service in the stack without the JSON log driver configuration (max-file: 5, max-size: 10m). Without log rotation, MariaDB's container logs can grow unboundedly and potentially cause disk exhaustion in busy environments.
Unless there is a deliberate reason to treat MariaDB differently (e.g., relying on MariaDB's own internal log management), <<: *x-logging should be restored for consistency with every other service in the file.
| mariadb: | |
| image: mariadb:10.11 # fix issues when upgrading using: mysql_upgrade -u root -p | |
| image: mariadb:10.11 | |
| container_name: appwrite-mariadb | |
| <<: *x-logging | |
| restart: unless-stopped | |
| networks: | |
| mariadb: | |
| image: mariadb:10.11 | |
| container_name: appwrite-mariadb | |
| <<: *x-logging | |
| restart: unless-stopped | |
| networks: | |
| - appwrite |
What does this PR do?
(Provide a description of what this PR does.)
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)
Related PRs and Issues
(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)
Have you read the Contributing Guidelines on issues?
(Write your answer here.)