Skip to content

chore(project): quality improvements#242

Merged
krokoko merged 3 commits into
mainfrom
qualityImprovements
Jun 2, 2026
Merged

chore(project): quality improvements#242
krokoko merged 3 commits into
mainfrom
qualityImprovements

Conversation

@krokoko
Copy link
Copy Markdown
Contributor

@krokoko krokoko commented Jun 2, 2026

  • add a failure in case of code coverage not being met (enforcing the rule)
  • update the review pr command
  • add new mise commands to run drift prevention mechanism as part of build

Area

  • cdk — infrastructure, handlers, constructs
  • agent — Python runtime / Docker image
  • clibgagent client
  • docs — guides or design sources (docs/guides/, docs/design/)
  • tooling — root mise.toml, scripts, CI workflows

Tip: AGENTS.md lists where to edit and which tests to extend.

Related

Changes

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.

@krokoko krokoko requested a review from a team as a code owner June 2, 2026 22:16
Copy link
Copy Markdown
Contributor

@isadeks isadeks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two things to fix before this can merge — otherwise the shape looks good.

  1. Broken Starlight link in
    docs/src/content/docs/developer-guide/Contributing.md:61

The mirror points at /architecture/review-pr, which doesn't exist on the docs
site (no Review-pr.md under docs/src/content/docs/architecture/). The root
CONTRIBUTING.md:57 correctly uses a repo-relative path to
.abca/commands/review_pr.md, but that path doesn't translate to the published
site, so the mirror was hand-edited to a URL that goes nowhere.

Suggested fix: since .abca/commands/ isn't part of the published docs, link to
the GitHub source directly, or drop the link in the Starlight version and
keep the prose. Whichever you pick, please confirm mise //docs:sync
regenerates a consistent result (i.e. the source markdown's relative link is
what produces this absolute URL, not a manual edit).

  1. agent/uv.lock revision downgraded 3 → 1

The header flipped from revision = 3 to revision = 1, and the 1425-line diff
is essentially stripping upload-time = "..." from every package entry — that's
the schema an older uv produces. Adding pytest-cov==7.1.0 alone should be a
~10-line diff. The next maintainer running uv sync with the project's pinned
uv will silently re-bump it to revision 3 and re-add all the metadata,
churning the lockfile again.

Suggested fix: regenerate the lockfile using the project-pinned uv (mise has
0.11.x available; looks like this was generated against an older Homebrew uv
0.9.9), then push only the actual pytest-cov addition.

Once those are addressed I'm happy to re-review. The contract → enforcement →
drift-check triad and the four-dimension heuristic in review_pr.md are well
done.

@krokoko krokoko added this pull request to the merge queue Jun 2, 2026
Merged via the queue into main with commit e3abe92 Jun 2, 2026
6 checks passed
@krokoko krokoko deleted the qualityImprovements branch June 2, 2026 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants