Fix protocol dependencies for smithy-rpc-v2-cbor when creating new service module#6265
Merged
alextwoods merged 2 commits intomasterfrom Jul 17, 2025
Merged
Fix protocol dependencies for smithy-rpc-v2-cbor when creating new service module#6265alextwoods merged 2 commits intomasterfrom
alextwoods merged 2 commits intomasterfrom
Conversation
dagnir
approved these changes
Jul 16, 2025
dagnir
approved these changes
Jul 16, 2025
Contributor
Author
|
Surface area API review is incorrectly flagging this as a change to a public/protected API - this is a change to only the constant used for substitution of protocol dependencies when creating new service modules. |
kstich
approved these changes
Jul 16, 2025
|
|
This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Fix protocol dependencies for smithy-rpc-v2-cbor when creating new service module
Motivation and Context
When new modules are created for rpcv2 cbor services we are currently incorrectly specifing the protocol dependency in the pom.xml, example error:
This is because the protocol name used in
transformSpecialProtocolsfor rpcv2 is incorrect. The correct value for the protocol from c2j files issmithy-rpc-v2-cbor.Modifications
Testing
Manual testing.
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License