Returning correct operation name for DeleteTableOperation#6791
Closed
andreas-grafenberger wants to merge 1 commit intoaws:masterfrom
Closed
Returning correct operation name for DeleteTableOperation#6791andreas-grafenberger wants to merge 1 commit intoaws:masterfrom
andreas-grafenberger wants to merge 1 commit intoaws:masterfrom
Conversation
2569089 to
88d518e
Compare
88d518e to
6eb60bd
Compare
Contributor
Author
|
PR was closed because the source branch was renamed to comply with the branch naming convention, which required recreating the PR: Returning correct operation name for DeleteTableOperation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR addresses the bug reported here: DeleteTableOperation uses OperationName.DELETE_ITEM instead of OperationName.DELETE_TABLE #6760.
Without this fix,
DeleteTableOperation#operationName()will continue to return a wrong operation name (OperationName.DELETE_ITEM). This is important because the operation actually performs a table deletion, and the reported name can be used by shared framework flows such as routing, logging, metrics, tracing, interceptors, error handling, and tests, where an incorrect value would mislabel the operation and create misleading behavior or observability data.Modifications
Replaced the operation name returned by
DeleteTableOperation#operationName(), fromOperationName.DELETE_ITEMtoOperationName.DELETE_TABLE.Testing
Added unit tests for modified operation name (from
DeleteTableOperation.java):operationName_returnsDeleteTable()- ConfirmsoperationName()returnsOperationName.DELETE_TABLEAdded additional tests to increase the class coverage (
DeleteTableOperation.java):getAsyncServiceCall_makesTheRightCallAndReturnsResponse()- ConfirmsasyncServiceCall(...)callsdeleteTable(...), passes the same request object, and returns the sameCompletableFuture.transformResponse_returnsNull()- ConfirmstransformResponse(...)returnsnullScreenshots (if appropriate)
Test coverage on modified classes
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License