Skip to content

Returning correct operation name for DeleteTableOperation#6791

Closed
andreas-grafenberger wants to merge 1 commit intoaws:masterfrom
andreas-grafenberger:bug/fix_delete_table_operation_name
Closed

Returning correct operation name for DeleteTableOperation#6791
andreas-grafenberger wants to merge 1 commit intoaws:masterfrom
andreas-grafenberger:bug/fix_delete_table_operation_name

Conversation

@andreas-grafenberger
Copy link
Contributor

@andreas-grafenberger andreas-grafenberger commented Mar 13, 2026

Motivation and Context

This PR addresses the bug reported here: DeleteTableOperation uses OperationName.DELETE_ITEM instead of OperationName.DELETE_TABLE #6760.

Without this fix, DeleteTableOperation#operationName() will continue to return a wrong operation name (OperationName.DELETE_ITEM). This is important because the operation actually performs a table deletion, and the reported name can be used by shared framework flows such as routing, logging, metrics, tracing, interceptors, error handling, and tests, where an incorrect value would mislabel the operation and create misleading behavior or observability data.

Modifications

Replaced the operation name returned by DeleteTableOperation#operationName(), from OperationName.DELETE_ITEM to OperationName.DELETE_TABLE.

Testing

Added unit tests for modified operation name (from DeleteTableOperation.java):

  • operationName_returnsDeleteTable() - Confirms operationName() returns OperationName.DELETE_TABLE

Added additional tests to increase the class coverage (DeleteTableOperation.java):

  • getAsyncServiceCall_makesTheRightCallAndReturnsResponse() - Confirms asyncServiceCall(...) calls deleteTable(...), passes the same request object, and returns the same CompletableFuture.
  • transformResponse_returnsNull() - Confirms transformResponse(...) returns null

Screenshots (if appropriate)

Test coverage on modified classes

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@andreas-grafenberger andreas-grafenberger requested a review from a team as a code owner March 13, 2026 08:56
@andreas-grafenberger andreas-grafenberger force-pushed the bug/fix_delete_table_operation_name branch from 2569089 to 88d518e Compare March 13, 2026 09:56
@andreas-grafenberger andreas-grafenberger force-pushed the bug/fix_delete_table_operation_name branch from 88d518e to 6eb60bd Compare March 13, 2026 10:21
@andreas-grafenberger andreas-grafenberger deleted the bug/fix_delete_table_operation_name branch March 13, 2026 11:54
@andreas-grafenberger andreas-grafenberger restored the bug/fix_delete_table_operation_name branch March 13, 2026 11:56
@andreas-grafenberger andreas-grafenberger deleted the bug/fix_delete_table_operation_name branch March 13, 2026 11:59
@andreas-grafenberger
Copy link
Contributor Author

PR was closed because the source branch was renamed to comply with the branch naming convention, which required recreating the PR: Returning correct operation name for DeleteTableOperation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant