feat: S3 transfer manager improvements#3247
feat: S3 transfer manager improvements#3247yenfryherrerafeliz wants to merge 11 commits intoaws:masterfrom
Conversation
Until phpunit10 support is release we must use annotations for covers and dataProvider within tests.
yenfryherrerafeliz
changed the title
| $resumeFilePath, | ||
| $this->downloadRequestArgs, | ||
| $config, | ||
| $this->initialRequestResult, |
There was a problem hiding this comment.
I think these args are out of order based on the ResumableDownload constructor
| * @param int $objectsDownloaded | ||
| * @param int $objectsFailed | ||
| * @param Throwable|null $reason | ||
| * @param array $reasons |
| */ | ||
| public static function computeObjectSizeFromContentRange( | ||
| string $contentRange | ||
| ): int |
There was a problem hiding this comment.
does this return int or string?
| * | ||
| * @return int | ||
| */ | ||
| public static function getRangeTo(string $range): int |
| * | ||
| * @return string|null | ||
| */ | ||
| public static function filterChecksum(array $parameters):? string |
There was a problem hiding this comment.
nit: no space after nullable for return types
| int $transferredBytes, | ||
| int $totalBytes, | ||
| ?array $response = null, | ||
| string $identifier, |
There was a problem hiding this comment.
extra spaces and closing brace is out of position
There was a problem hiding this comment.
I think this has some redundant getters it inherits from AbstractResumableTransfer, same with ResumableUpload
There was a problem hiding this comment.
Should also have a corresponding test class
There was a problem hiding this comment.
should have a corresponding test class
There was a problem hiding this comment.
should have a corresponding test class
There was a problem hiding this comment.
should have a corresponding test class
2 participants
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.