-
-
Notifications
You must be signed in to change notification settings - Fork 688
feat(coverage): warn when bundled coverage tool has no wheel for requested python_version/platform with tests #3767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Syndic
wants to merge
3
commits into
bazel-contrib:main
Choose a base branch
from
Syndic:coverage-warn-when-missing-tested
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+139
−11
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| # Copyright 2026 The Bazel Authors. All rights reserved. | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| load(":coverage_deps_test.bzl", "coverage_deps_test_suite") | ||
|
|
||
| coverage_deps_test_suite(name = "coverage_deps_tests") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,77 @@ | ||
| # Copyright 2026 The Bazel Authors. All rights reserved. | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| "Tests for coverage_url_sha256 lookups against the bundled wheel set." | ||
|
|
||
| load("@rules_testing//lib:test_suite.bzl", "test_suite") | ||
| load("//python/private:coverage_deps.bzl", "coverage_url_sha256") # buildifier: disable=bzl-visibility | ||
|
|
||
| _tests = [] | ||
|
|
||
| def _test_supported_version_and_platform_returns_url_and_sha(env): | ||
| result = coverage_url_sha256("3.10", "aarch64-apple-darwin") | ||
| env.expect.that_bool(result != None).equals(True) | ||
| url, sha256 = result | ||
| env.expect.that_str(url).contains("coverage-") | ||
| env.expect.that_str(url).contains("cp310") | ||
| env.expect.that_str(url).contains("macosx_11_0_arm64") | ||
| env.expect.that_int(len(sha256)).equals(64) | ||
|
|
||
| _tests.append(_test_supported_version_and_platform_returns_url_and_sha) | ||
|
|
||
| def _test_cp314_is_in_bundled_set(env): | ||
| # Regression guard: cp314 was the motivation for adding the warning. | ||
| # If a future regen accidentally drops it, this test fires. | ||
| result = coverage_url_sha256("3.14", "aarch64-apple-darwin") | ||
| env.expect.that_bool(result != None).equals(True) | ||
| url, _ = result | ||
| env.expect.that_str(url).contains("cp314") | ||
|
|
||
| _tests.append(_test_cp314_is_in_bundled_set) | ||
|
|
||
| def _test_freethreaded_variant_is_in_bundled_set(env): | ||
| # Regression guard: freethreaded variants for cp313+ are part of the | ||
| # bundled set; ensure regen does not drop them. | ||
| result = coverage_url_sha256("3.14", "aarch64-apple-darwin-freethreaded") | ||
| env.expect.that_bool(result != None).equals(True) | ||
| url, _ = result | ||
| env.expect.that_str(url).contains("cp314t") | ||
|
|
||
| _tests.append(_test_freethreaded_variant_is_in_bundled_set) | ||
|
|
||
| def _test_unsupported_version_returns_none(env): | ||
| # Python 3.7 is not in the bundled wheel set (and is far below the | ||
| # current floor). This is the path that triggers the warning in | ||
| # coverage_dep. | ||
| result = coverage_url_sha256("3.7", "aarch64-apple-darwin") | ||
| env.expect.that_bool(result == None).equals(True) | ||
|
|
||
| _tests.append(_test_unsupported_version_returns_none) | ||
|
|
||
| def _test_windows_returns_none(env): | ||
| # Windows is intentionally not supported by the bundled coverage tool; | ||
| # the lookup must return None so the caller can keep the windows | ||
| # branch silent. | ||
| result = coverage_url_sha256("3.10", "x86_64-pc-windows-msvc") | ||
| env.expect.that_bool(result == None).equals(True) | ||
|
|
||
| _tests.append(_test_windows_returns_none) | ||
|
|
||
| def coverage_deps_test_suite(name): | ||
| """Create the test suite. | ||
|
|
||
| Args: | ||
| name: the name of the test suite | ||
| """ | ||
| test_suite(name = name, basic_tests = _tests) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.