Skip to content

CI: fix Haiku git safe.directory issue, fixes #9562#9563

Merged
ThomasWaldmann merged 1 commit intoborgbackup:masterfrom
mr-raj12:fix/haiku-ci-safe-directory
Apr 7, 2026
Merged

CI: fix Haiku git safe.directory issue, fixes #9562#9563
ThomasWaldmann merged 1 commit intoborgbackup:masterfrom
mr-raj12:fix/haiku-ci-safe-directory

Conversation

@mr-raj12
Copy link
Copy Markdown
Contributor

@mr-raj12 mr-raj12 commented Apr 5, 2026

Description

cross-platform-actions rsyncs the repo into the Haiku VM under a different file owner than the shell user. Now, calls git at the "getting requirements to build editable" phase which triggers git's dubious-ownership check and breaks the build.

Fix: set safe.directory before pip install.

fixes #9562

Checklist

  • PR is against master
  • New code has tests and docs where appropriate
  • Tests pass
  • Commit messages are clean and reference related issues

@ThomasWaldmann
Copy link
Copy Markdown
Member

Check this: cross-platform-actions/action#108

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.40%. Comparing base (60596bd) to head (cb83cc1).
⚠️ Report is 12 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9563      +/-   ##
==========================================
+ Coverage   83.36%   83.40%   +0.03%     
==========================================
  Files          87       87              
  Lines       15481    15489       +8     
  Branches     2325     2326       +1     
==========================================
+ Hits        12906    12918      +12     
  Misses       1821     1821              
+ Partials      754      750       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mr-raj12
Copy link
Copy Markdown
Contributor Author

mr-raj12 commented Apr 6, 2026

Check this: cross-platform-actions/action#108

have raised the mentioned fix there

@ThomasWaldmann ThomasWaldmann merged commit c72b90b into borgbackup:master Apr 7, 2026
16 checks passed
@ThomasWaldmann
Copy link
Copy Markdown
Member

We'll use this for now until it is fixed / released upstream.

Thanks for fixing!

@mr-raj12
Copy link
Copy Markdown
Contributor Author

mr-raj12 commented Apr 9, 2026

We'll use this for now until it is fixed / released upstream.

Thanks for fixing!

Its merged, we can revert the these changes once they have a new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci: Haiku job fails since setuptools 78.x as git safe.directory not set before pip install

2 participants