feat(dispatcher): add ability to wait for job completion#10
Draft
kerwanp wants to merge 1 commit intoboringnode:mainfrom
Draft
feat(dispatcher): add ability to wait for job completion#10kerwanp wants to merge 1 commit intoboringnode:mainfrom
kerwanp wants to merge 1 commit intoboringnode:mainfrom
Conversation
14e4284 to
05eb6d2
Compare
kerwanp
commented
Mar 24, 2026
| * @param signal - Optional signal to abort waiting | ||
| * @returns The job output | ||
| */ | ||
| async wait(pollingInterval: Duration = 2000, signal?: AbortSignal): Promise<TOutput> { |
Contributor
Author
There was a problem hiding this comment.
We might want to add a default timeout based on the job timeout option.
Could make DX simpler with an explicit timeout option (less flexible than signal)
Member
|
i think, one issue with the current approach is that if retention is disabled, it wont work. it even throw, because we are calling |
Contributor
Author
|
Yes, everything is mentioned here #9 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.