fix: rolldown support - stop importing from rollup in the published types#218
Open
birkskyum wants to merge 3 commits into
Open
fix: rolldown support - stop importing from rollup in the published types#218birkskyum wants to merge 3 commits into
birkskyum wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #219
Fix
Replaces hard imports of
Plugin,OutputOptions,OutputChunk, andGetModuleInfofrom"rollup"inplugin/{index,sourcemap,data}.tswith structural stubs in a newplugin/rollup-types.ts. The stubs are subsets of bothrollup's androlldown's types, sovisualizer()'s return value still drops cleanly into either bundler'spluginsarray.generateBundleis typed=> void | Promise<void>(rollup's signature; also accepted by rolldown's stricter=> void). Internal types (OutputBundle,NormalizedOutputOptions) keep theirimport typefrom"rollup"since they don't leak into the emitted.d.ts.Test plan
tsc --noEmitexits 0npm testnpm run lintgrep 'from "rollup"' dist/.d.ts