Skip to content

Replace anyhow with wasmtime_internal_error #12309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fitzgen merged 2 commits into from
Jan 14, 2026
Merged

Replace anyhow with wasmtime_internal_error #12309

fitzgen merged 2 commits into from
Jan 14, 2026
+8 −18

Conversation

@fitzgen
Copy link
Member

@fitzgen fitzgen commented Jan 9, 2026

This replaces wasmtime-environ's dependency on anyhow -- and its re-export of that crate as wasmtime_environ::error, which the wasmtime crate re-exports as wasmtime::error in turn -- with our own wasmtime_internal_error crate. Our crate is API compatible with anyhow, but additionally allows for handling out-of-memory, memory-exhaustion, and allocation-failure errors.

This will let us proceed with the efforts tracked in #12069

Builds on top of #12308

@fitzgen fitzgen requested review from a team as code owners January 9, 2026 20:43
@fitzgen fitzgen requested review from dicej and removed request for a team January 9, 2026 20:43
@fitzgen fitzgen mentioned this pull request Jan 9, 2026
Merged
@fitzgen fitzgen force-pushed the replace-anyhow-with-wasmtime-internal-error branch from 3caec67 to 6e5fd91 Compare January 9, 2026 20:53
@fitzgen
Copy link
Member Author

fitzgen commented Jan 9, 2026

The cargo vet fix included here is also split out into its own PR over here: #12310

@alexcrichton
Copy link
Member

alexcrichton commented Jan 9, 2026

I'd recommend prtest:full on this PR too to avoid merge-queue-based surprises

@github-actions github-actions bot added wasmtime:api Related to the API of the `wasmtime` crate itself wizer Issues related to Wizer snapshotting, pre-initialization, and the `wasmtime wizer` subcommand labels Jan 9, 2026
@github-actions
Copy link

github-actions bot commented Jan 9, 2026

Subscribe to Label Action

cc @fitzgen

Details This issue or pull request has been labeled: "wasmtime:api", "wizer"

Thus the following users have been cc'd because of the following labels:

  • fitzgen: wizer

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

@fitzgen fitzgen force-pushed the replace-anyhow-with-wasmtime-internal-error branch from 6e5fd91 to 3f45f94 Compare January 12, 2026 21:01
@fitzgen fitzgen requested a review from a team as a code owner January 12, 2026 21:01
@fitzgen fitzgen requested review from alexcrichton and removed request for a team January 12, 2026 21:01
@fitzgen
Copy link
Member Author

fitzgen commented Jan 12, 2026

This PR depends on #12324 as well

@github-actions github-actions bot added the fuzzing Issues related to our fuzzing infrastructure label Jan 12, 2026
@github-actions
Copy link

github-actions bot commented Jan 12, 2026

Subscribe to Label Action

cc @fitzgen

Details This issue or pull request has been labeled: "fuzzing"

Thus the following users have been cc'd because of the following labels:

  • fitzgen: fuzzing

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

@fitzgen fitzgen force-pushed the replace-anyhow-with-wasmtime-internal-error branch 2 times, most recently from ca06298 to bcc70d0 Compare January 13, 2026 19:37
@fitzgen
Copy link
Member Author

fitzgen commented Jan 13, 2026

All of this PR's blockers have merged, I've rebased on main, and added prtest:full to the commit message. All that is left is final review and this can merge.

@fitzgen fitzgen mentioned this pull request Jan 13, 2026
Merged
@fitzgen fitzgen force-pushed the replace-anyhow-with-wasmtime-internal-error branch from bcc70d0 to b7eb67b Compare January 13, 2026 20:44
@fitzgen
Copy link
Member Author

fitzgen commented Jan 13, 2026

Found a bug in the wit-bindgen generated code with anyhow: true and peeled that off into #12334

@fitzgen fitzgen force-pushed the replace-anyhow-with-wasmtime-internal-error branch 2 times, most recently from 710bd25 to 70c1b4b Compare January 14, 2026 00:01
@fitzgen
Copy link
Member Author

fitzgen commented Jan 14, 2026

Depends on #12343

alexcrichton
alexcrichton approved these changes Jan 14, 2026
View reviewed changes
Copy link
Member

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like all that's left is a top-o sort of the publish.rs list of crates, thanks again for pushing through all this and working on all the PRs!

@fitzgen
Replace anyhow with wasmtime_internal_error
1779161 
This replaces `wasmtime-environ`'s dependency on `anyhow` -- and its re-export
of that crate as `wasmtime_environ::error`, which the `wasmtime` crate
re-exports as `wasmtime::error` in turn -- with our own
`wasmtime_internal_error` crate. Our crate is API compatible with `anyhow`, but
additionally allows for handling out-of-memory, memory-exhaustion, and
allocation-failure errors.

This will let us proceed with the efforts tracked in
bytecodealliance#12069

prtest:full
@fitzgen fitzgen force-pushed the replace-anyhow-with-wasmtime-internal-error branch from 70c1b4b to 24bdb9f Compare January 14, 2026 19:20
@fitzgen fitzgen enabled auto-merge January 14, 2026 19:20
@fitzgen fitzgen added this pull request to the merge queue Jan 14, 2026
Merged via the queue into bytecodealliance:main with commit e2fbd14 Jan 14, 2026
174 checks passed
@fitzgen fitzgen deleted the replace-anyhow-with-wasmtime-internal-error branch January 14, 2026 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexcrichton alexcrichton alexcrichton approved these changes

@dicej dicej Awaiting requested review from dicej dicej is a code owner automatically assigned from bytecodealliance/wasmtime-core-reviewers

Assignees

No one assigned

Labels

fuzzing Issues related to our fuzzing infrastructure wasmtime:api Related to the API of the `wasmtime` crate itself wizer Issues related to Wizer snapshotting, pre-initialization, and the `wasmtime wizer` subcommand

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fitzgen @alexcrichton